This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A patch for elf/dl-deps.c


On Mon, Apr 09, 2001 at 12:16:18PM -0700, H . J . Lu wrote:
> We should preserve the real error message.

That looks very unsafe to me, try testing glibc with your patch under
efence.
E.g.:
                    if (_dl_catch_error (&objname, &errstring, openaux, &args))
                      {
                        /* We are not interested in the error message.  */
                        assert (errstring != NULL);
                        if (errstring != _dl_out_of_memory)
                          free ((char *) errstring);

will surely not end up with valid errstring.

> 2001-04-09  H.J. Lu  <hjl@gnu.org>
> 
> 	* elf/dl-deps.c (_dl_map_object_deps): Preserve the real error
> 	message.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]