This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: A patch for elf/dl-deps.c
- To: "H . J . Lu" <hjl at lucon dot org>
- Subject: Re: A patch for elf/dl-deps.c
- From: Jakub Jelinek <jakub at redhat dot com>
- Date: Tue, 10 Apr 2001 18:57:06 +0200
- Cc: GNU C Library <libc-alpha at sourceware dot cygnus dot com>
- References: <20010409121618.A27900@lucon.org>
- Reply-To: Jakub Jelinek <jakub at redhat dot com>
On Mon, Apr 09, 2001 at 12:16:18PM -0700, H . J . Lu wrote:
> We should preserve the real error message.
That looks very unsafe to me, try testing glibc with your patch under
efence.
E.g.:
if (_dl_catch_error (&objname, &errstring, openaux, &args))
{
/* We are not interested in the error message. */
assert (errstring != NULL);
if (errstring != _dl_out_of_memory)
free ((char *) errstring);
will surely not end up with valid errstring.
> 2001-04-09 H.J. Lu <hjl@gnu.org>
>
> * elf/dl-deps.c (_dl_map_object_deps): Preserve the real error
> message.
Jakub