This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: LinuxThreads cancellation bug.
- To: Kaz Kylheku <kaz at ashi dot footprints dot net>
- Subject: Re: LinuxThreads cancellation bug.
- From: Ulrich Drepper <drepper at redhat dot com>
- Date: 06 Nov 2000 16:39:12 -0800
- Cc: libc-alpha at sources dot redhat dot com
- References: <Pine.LNX.4.10.10011060925020.7940-100000@ashi.FootPrints.net>
- Reply-To: drepper at cygnus dot com (Ulrich Drepper)
Kaz Kylheku <kaz@ashi.footprints.net> writes:
> If cancelation is disabled the pthread_cancel function bails without
> recording that a cancelation request was made. This is incorrect
> behavior, because the application cannot temporarily disable
> cancelation around code without potentially losing a cancelation
> request.
I agree with this.
> I believe that the fix is simply to remove the test.
This surely isn't true. Instead we probably should move
th->p_canceled = 1;
before the test. The next cancelstate change will then have the
desired effect.
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------