This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
run iconvdata shell tests using $SHELL
- To: libc-alpha at sources dot redhat dot com
- Subject: run iconvdata shell tests using $SHELL
- From: Pete Wyckoff <pw at osc dot edu>
- Date: Sun, 15 Oct 2000 15:39:50 -0400
>Submitter-Id: net
>Originator: Pete Wyckoff
>Organization:
>Confidential: no
>Synopsis: make check fails in iconvdata due to nonexecutable scripts
>Severity: non-critical
>Priority: low
>Category: libc
>Class: sw-bug
>Release: libc-2.1.95
>Environment:
Host type: i686-pc-linux-gnu
System: Linux bigger 2.4.0-test9 #4 SMP Sat Oct 7 14:58:52 EDT 2000 i686 unknown
Architecture: i686
Addons: linuxthreads
Build CC: gcc
Compiler version: 2.95.2 19991024 (release)
Kernel headers: 2.4.0-test9
Symbol versioning: yes
Build static: yes
Build shared: yes
Build pic-default: no
Build profile: yes
Build omitfp: no
Build bounded: no
Build static-nss: no
Stdio: libio
>Description:
Patching a previous glibc distribution (in my case, 2.1.93) won't
set executable perms on new files. Two shell scripts in
iconvdata try to execute others using "./tst-table-charmap.sh".
>How-To-Repeat:
make check
>Fix:
Re-invoke $SHELL explicitly. Could consider chmod in Makefiles,
entry in FAQ, or ignoring the problem since anybody playing with
diffs probably can figure out how to fix it.
2000-10-15 Pete Wyckoff <pw@osc.edu>
* iconvdata/tst-tables.sh: Invoke other shell scripts through ${SHELL}.
* iconvdata/tst-table.sh: Likewise.
diff -ruN glibc-2.1.95/iconvdata/tst-tables.sh glibc/iconvdata/tst-tables.sh
--- glibc-2.1.95/iconvdata/tst-tables.sh Sun Oct 15 13:14:51 2000
+++ glibc/iconvdata/tst-tables.sh Sun Oct 15 13:13:56 2000
@@ -209,7 +209,7 @@
if test "$charset" = GB18030; then echo "This might take a while" 1>&2; fi
case ${charset} in \#*) continue;; esac
echo -n "Testing ${charset}" 1>&2
- if ./tst-table.sh ${common_objpfx} ${objpfx} ${charset} ${charmap}; then
+ if ${SHELL} tst-table.sh ${common_objpfx} ${objpfx} ${charset} ${charmap}; then
echo 1>&2
else
echo "failed: ./tst-table.sh ${common_objpfx} ${objpfx} ${charset} ${charmap}"
diff -ruN glibc-2.1.95/iconvdata/tst-table.sh glibc/iconvdata/tst-table.sh
--- glibc-2.1.95/iconvdata/tst-table.sh Sun Oct 15 13:14:44 2000
+++ glibc/iconvdata/tst-table.sh Sun Oct 15 13:13:56 2000
@@ -34,7 +34,7 @@
set -e
# Get the charmap.
-./tst-table-charmap.sh ${charmap:-$charset} \
+${SHELL} tst-table-charmap.sh ${charmap:-$charset} \
< ../localedata/charmaps/${charmap:-$charset} \
> ${objpfx}tst-${charset}.charmap.table