This is the mail archive of the
kawa@sources.redhat.com
mailing list for the Kawa project.
Re: 2 patches
- From: Jim White <jim at pagesmiths dot com>
- To: kawa at sources dot redhat dot com
- Date: Fri, 09 Aug 2002 03:17:27 -0700
- Subject: Re: 2 patches
- References: <3D536C14.EE8AB13A@st.com>
Marco Vezzoli wrote:
1st patch: build.xml
I tried to modify build.xml in order to compile HTTP.scm and have
(require 'http) working but there are some bad dependancies to be fixed
(HTTP.scm needs xml-classes and servlet-classes to be compiled BEFORE)
and problems with ant tasks (see comments) so this patch is more a
suggestion than a fix.
I don't agree with this suggested change. The Ant build purposely
relies on the CLASSPATH environment variable for finding classes
installed in the system. And if the classpath were to be managed in
this way, the settings would go in build.properties, not build.xml.
Attached is a patch for build.xml which compiles HTTP.scm. Just add
servlet.jar to your CLASSPATH or copy/link it into $ANT_HOME/lib. I got
lazy and didn't put in the up-to-date check for it, so it gets compiled
every time. I should whip up a <kawa> task to handle that.
Also Marco, note that your patches are reversed (swap the order of the
file names for a normal patch).
jim
Index: build.xml
===================================================================
RCS file: /cvs/kawa/kawa/build.xml,v
retrieving revision 1.10
diff -u -r1.10 build.xml
--- build.xml 26 Jun 2002 21:36:00 -0000 1.10
+++ build.xml 9 Aug 2002 10:11:24 -0000
@@ -579,6 +579,17 @@
optimize="${optimize}" >
<include name="gnu/kawa/servlet/"/>
</javac>
+ <apply taskname="kawa" executable="java"
+ failonerror="true" parallel="true">
+ <!-- I don't quite get why the Java classpath has to be tacked on here, but it does. -->
+ <arg value="-classpath"/> <arg path="${build.classes}:${java.class.path}"/>
+ <arg value="kawa.repl"/>
+ <arg value="-d"/> <arg path="${build.classes}"/>
+ <arg line="-P gnu.kawa.slib. --module-static -C"/>
+ <fileset dir="${src.dir}/gnu/kawa/slib">
+ <include name="HTTP.scm"/>
+ </fileset>
+ </apply>
</target>
<fileset id="jemacs-lang-scm" dir="${src.dir}/gnu/jemacs/lang">