Errors building insight top-of-tree.

[David Fernandez <dfernandez at solarflare dot com>]

Hi there,

I've picked top-of-tree and tried to build it for avr target in 
Fedora20. I've got this:

gcc -DHAVE_CONFIG_H -DPROFILE=1 -DWITH_PROFILE=-1 -DDEFAULT_INLINE=0 -I. 
-I/home/df/src/insight-trunk/src/sim/avr -I../common 
-I/home/df/src/insight-trunk/src/sim/avr/../common -I../../include 
-I/home/df/src/insight-trunk/src/sim/avr/../../include -I../../bfd 
-I/home/df/src/insight-trunk/src/sim/avr/../../bfd -I../../opcodes 
-I/home/df/src/insight-trunk/src/sim/avr/../../opcodes -g -O2 -c -o 
callback.o -MT callback.o -MMD -MP -MF .deps/callback.Tpo 
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:65:20: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
void sim_cb_printf PARAMS ((host_callback *, const char *, ...));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:66:21: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
void sim_cb_eprintf PARAMS ((host_callback *, const char *, ...));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:72:19: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
extern int system PARAMS ((const char *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:74:20: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_init PARAMS ((host_callback *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:75:24: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_shutdown PARAMS ((host_callback *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:76:22: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_unlink PARAMS ((host_callback *, const char *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:77:21: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static long os_time PARAMS ((host_callback *, long *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:78:22: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_system PARAMS ((host_callback *, const char *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:79:22: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_rename PARAMS ((host_callback *, const char *, const char *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:80:28: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_write_stdout PARAMS ((host_callback *, const char *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:81:29: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static void os_flush_stdout PARAMS ((host_callback *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:82:28: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_write_stderr PARAMS ((host_callback *, const char *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:83:29: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static void os_flush_stderr PARAMS ((host_callback *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:84:21: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_write PARAMS ((host_callback *, int, const char *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:85:26: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_read_stdin PARAMS ((host_callback *, char *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:86:20: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_read PARAMS ((host_callback *, int, char *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:87:20: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_open PARAMS ((host_callback *, const char *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:88:21: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_lseek PARAMS ((host_callback *, int, long, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:89:22: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_isatty PARAMS ((host_callback *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:90:25: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_get_errno PARAMS ((host_callback *));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:91:21: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int os_close PARAMS ((host_callback *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:92:33: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static void os_vprintf_filtered PARAMS ((host_callback *, const char *, 
va_list));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:93:34: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static void os_evprintf_filtered PARAMS ((host_callback *, const char *, 
va_list));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:94:22: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static void os_error PARAMS ((host_callback *, const char *, ...))
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:99:18: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int fdmap PARAMS ((host_callback *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:100:18: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int fdbad PARAMS ((host_callback *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:101:17: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘PARAMS’
static int wrap PARAMS ((host_callback *, int));
^
/home/df/src/insight-trunk/src/sim/avr/../common/callback.c:833:3: 
warning: initialization makes ‘__attribute__((noreturn))’ qualified 
function pointer from unqualified [enabled by default]
os_error,
^
make[3]: *** [callback.o] Error 1
make[3]: Leaving directory `/home/df/build/insight/avr/sim/avr'
make[2]: *** [all] Error 1
make[2]: Leaving directory `/home/df/build/insight/avr/sim'
make[1]: *** [all-sim] Error 2
make[1]: Leaving directory `/home/df/build/insight/avr'
make: *** [all] Error 2
make: Leaving directory `/home/df/build/insight/avr'

Is this expected for the top-of-tree?

Otherwise, may be you could suggest a quick fix for that PARAMS that 
seems undefined.

Regards
David

PS.
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.2/lto-wrapper
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man 
--infodir=/usr/share/info 
--with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap 
--enable-shared --enable-threads=posix --enable-checking=release 
--with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions 
--enable-gnu-unique-object --enable-linker-build-id 
--with-linker-hash-style=gnu 
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto 
--enable-plugin --enable-initfini-array --enable-java-awt=gtk 
--disable-dssi --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre 
--enable-libgcj-multifile --enable-java-maintainer-mode 
--with-ecj-jar=/usr/share/java/eclipse-ecj.jar 
--disable-libjava-multilib 
--with-isl=/builddir/build/BUILD/gcc-4.8.2-20131212/obj-x86_64-redhat-linux/isl-install 
--with-cloog=/builddir/build/BUILD/gcc-4.8.2-20131212/obj-x86_64-redhat-linux/cloog-install 
--with-tune=generic --with-arch_32=i686 --build=x86_64-redhat-linux
Thread model: posix
gcc version 4.8.2 20131212 (Red Hat 4.8.2-7) (GCC)

$ avr-gcc -v
Using built-in specs.
COLLECT_GCC=avr-gcc
COLLECT_LTO_WRAPPER=/home/df/local/libexec/gcc/avr/4.8.2/lto-wrapper
Target: avr
Configured with: /home/df/src/gcc-4.8.2/configure 
--prefix=/home/df/local --target=avr --enable-languages=c,c++ 
--with-gnu-as --with-gnu-ld 
--with-gxx-include-dir=/home/df/local/avr/include --with-dwarf2 
--disable-libssp -v
Thread model: single
gcc version 4.8.2 (GCC)

$ uname -a
Linux df-desktop.uk.level5networks.com 3.12.10-300.fc20.x86_64 #1 SMP 
Thu Feb 6 22:11:48 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux