This is the mail archive of the
insight@sourceware.org
mailing list for the Insight project.
Re: [PATCH/gdbtk] Implement "Attach to process" for windows
- From: Roland Schwingel <roland at onevision dot com>
- To: insight at sourceware dot org
- Date: Mon, 25 Jun 2012 14:13:43 +0200
- Subject: Re: [PATCH/gdbtk] Implement "Attach to process" for windows
Hi,
After some long detour back again at my computers...
> You have two choices here...
> 1) Leave this as-is, change attachdlg so that it checks if the return
> from gdb_list_processes is empty and fallback to groking ps.
> 2) return TCL_OK inside _WIN32 and return TCL_ERROR to force
> attachdlg to fallback to groking ps.
I opted for case 1) now and implemented it that way. I tested it
on windows and linux and attach to process seems to run nicely on
both platforms.
I committed the patch now with the formatting issue mentioned by Keith
corrected.
Roland