This is the mail archive of the insight@sourceware.org mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove deprecated access to tcl internal variables


Hi Keith,

insight-owner@sourceware.org wrote on 27.03.2012 16:44:54:

> In any case, please add a
> ChangeLog entry for it, adjust the two formatting/CS discrepancies and
> this patch is good to go in.
I corrected the formatting of function calls and indents and expanded
the changelog and checked it in now.

New changelog:
2012-03-28  Roland Schwingel <roland.schwingel@onevision.com>

   * generic/gdbtk.c (gdbtk_init,tk_command): Replace deprecated access
   to tcl interpreter result string with Tcl_GetStringResult().
   * generic/gdbtk-hooks.c (gdbtk_read,gdbtk_readline,gdbtk_load_hash)
   (gdbtk_query): Likewise.
   (gdbtk_read): Simplified error handling in case "gdbtk_console_read"
   fails. Some reformatting.

Thanks for reviewing. :-)
Do you know when you will find time to look at my other patches?
At least the next four of my bulk are quite trivial.

Thanks,

Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]