Re: [PATCH] Recent GDB prompt/bp API updates

[Dave Murphy <davem at devkitpro dot org>]

On Tue, Aug 2, 2011 at 7:49 PM, Keith Seitz <keiths@redhat.com> wrote:
> On 08/01/2011 03:10 PM, Keith Seitz wrote:
>>
>> If there are any problems, please let me know.
>
> There was a problem: breakpoints could not be set through the Source Window.
> I have committed the attach patch to correct this.

> ? ? ? ?* generic/gdbtk-bp.c (gdb_set_bp): Pass a valid breakpoint_ops
> ? ? ? ?to create_breakpoint.

I see this change in CVS but a build of insight under msys/mingw still
can't seem to set breakpoints from the source window - this is for an
arm-eabi target if it makes any difference. Setting a breakpoint from
the console shows the red box in the source window and it can be
disabled from there just fine.

Also, oddly, some patching is needed to build with mingw/msys again
which I could have sworn was fixed some time ago. The patch is pretty
minor though. There's also a patch to config/tcl.m4 needed as well
which needs gdb/configure & gdb/gdbtk/plugins/configure regenerated -
does that belong to Insight or gdb? I've attached it here too.

2011-08-11  Dave Murphy  <davem@devkitpro.org>
       * libgui/configure.ac:  add mingw to win32 hosts
       * libgui/configure:     regenerate
       * tcl/win/tclWinChan.c  mark ESP/EBP as used
       * tcl/win/tclWinDde.c (Tcl_DdeObjCmd):  remove invalid lvalue cast

Attachment: insight-mingw.patch
Description: Binary data

Attachment: tcl.m4.patch
Description: Binary data