This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: [PATCH] Fix annoying startup srcbar bug
- To: Keith Seitz <keiths at cygnus dot com>
- Subject: Re: [PATCH] Fix annoying startup srcbar bug
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Mon, 04 Jun 2001 14:33:59 -0400
- CC: Insight Maling List <insight at sources dot redhat dot com>
- Organization: Red Hat , Inc. - Toronto
- References: <Pine.GSO.4.33.0106041014080.21788-100000@ryobi.cygnus.com>
Keith,
Have you tried this with remote targets?
Some of us tried this some time ago and we've got side-effects. It has been some time so I don't remember exactly but I vaguely recall it had something to do with remote targets...
Cheers,
Fernando
P.S.: I am now remembering something about having to add something to make them active again after you connect to a board, but if it is doing the right thing after you attach it is probably all right. It can also be a problem that only existed in the old code and I did not try to turn then off after the rewrite -- I am not sure.
Keith Seitz wrote:
>
> Hi,
>
> When Insight is started, the srcbar has all the target control buttons
> and menus enabled. Obviously, this is wrong.
>
> The following patch fixes that problem and disables the buttons/menus. I
> have verified that this does not interfere with attaching to a process
> from the command-line.
>
> Keith
>
> ChangeLog:
> 2001-06-04 Keith Seitz <keiths@redhat.com>
>
> * library/srcbar.itcl (constructor): Set the toolbar's initial
> state.
>
> Patch:
> Index: library/srcbar.itcl
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtk/library/srcbar.itcl,v
> retrieving revision 1.9
> diff -u -p -r1.9 srcbar.itcl
> --- srcbar.itcl 2001/05/31 20:32:58 1.9
> +++ srcbar.itcl 2001/06/04 17:15:19
> @@ -64,6 +64,9 @@ class SrcBar {
> # Pack the toolbar
> pack $Tool -expand 1 -fill both
>
> + # Set the srcbar's initial state
> + enable_ui 2
> +
> eval itk_initialize $args
> add_hook gdb_no_inferior_hook "$this enable_ui 2"
> add_hook gdb_trace_find_hook "$this handle_trace_find_hook"
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9