This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: Patch: fixlet in gdbtk-cmds.c
This looks good then.
At 02:57 PM 11/29/00 -0700, Tom Tromey wrote:
>Syd> I would rather have a global variable for whether a gdbtk command
>Syd> generated the error as opposed to Tcl itself rather than messing
>Syd> with interp result flags. This is just asking to break when the
>Syd> interp data structure is changed.
>
>I looked at this a bit more.
>
>In the code I quoted `result_ptr' is a global variable like that.
>This isn't the intepreter or the result.
>
>I think this patch does what I want:
>
>2000-11-29 Tom Tromey <tromey@cygnus.com>
>
> * gdbtk-cmds.c (call_wrapper): Don't reset result if wrapped
> command returned error.
>
>Unfortunately, it is unclear what negative ramifications, if any, this
>patch might have. I'd have to consider it "dangerous".
I guess we will have to see what happens then.
>Syd> I will examine this more in a couple of weeks.
Well, I am out of town and unable to hack until late next week. Oh, well.
Syd Polk spolk@redhat.com
Engineering Manager +1 415 777 9810 x 241
Red Hat, Inc.