Re: comment in managedwin.itb

[Tom Tromey <tromey at cygnus dot com>]

Syd> I hate commented it out code. I think you should restore the
Syd> command and give a concise comment about why you are not using
Syd> focus $top.

Actually, I think we shouldn't use focus at all.

* Using focus -force is unfriendly.  It steals the focus, which the
  user might not want.
* Using focus is pointless since it just moves the potential focus
  point in that window.  In general we don't want to do that.

How about this?

2000-11-28  Tom Tromey  <tromey@cygnus.com>

	* managedwin.itb (ManagedWin::reveal): Don't set focus.

Tom

Index: managedwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/managedwin.itb,v
retrieving revision 1.4
diff -u -r1.4 managedwin.itb
--- managedwin.itb	2000/03/29 03:18:16	1.4
+++ managedwin.itb	2000/11/29 04:16:39
@@ -40,11 +40,6 @@
   set top [winfo toplevel [namespace tail $this]]
   raise $top
   wm deiconify $top
-  
-  # I don't understand this next line and no one commented it, so it's gone.
-  #focus -force [focus -lastfor $top]
-  
-  focus $top
 }
 
 body ManagedWin::restart {} {