This is the mail archive of the
insight@sources.redhat.com
mailing list for the Insight project.
Re: Patch: fixlet in gdbtk-cmds.c
- To: Syd Polk <spolk at redhat dot com>
- Subject: Re: Patch: fixlet in gdbtk-cmds.c
- From: Tom Tromey <tromey at cygnus dot com>
- Date: 28 Nov 2000 14:56:04 -0700
- Cc: Insight List <insight at sourceware dot cygnus dot com>
- References: <4.2.0.58.20001128125809.01a7f100@pop.cygnus.com>
- Reply-To: tromey at cygnus dot com
>>>>> "Syd" == Syd Polk <spolk@redhat.com> writes:
Syd> Approved, although I would have preferred using Tcl_WrongNumArgs.
I wasn't even aware of that function. It must have been added since I
last used Tcl.
gdbtk-cmds.c uses the "broken" method everywhere. Bummer. Also,
gdb_get_breakpoint_list() uses error(), which seems wrong.
I looked in gdb/testsuite/gdb.gdbtk and I didn't see anything that
mentions `gdb_clear_file'. So I could check in the patch you prefer,
if you want.
Is there somewhere else I should look for tests?
Tom