This is the mail archive of the insight@sourceware.cygnus.com mailing list for the Insight project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: make check in itcl


>>>>> Syd Polk writes:

Syd> I checked it into sourceware; however, on second look, I don't think
Syd> it will work. When you run "make check" from the toplevel, you need to
Syd> run "make test" in the itcl subdirectories.

I've tested my first patch - but forgot to test that version :-(
Sorry about that.


Syd> +test check:
>> for dir in $(subdirs) ; do \
>> if (echo "Making in $$dir"; cd $$dir && $(MAKE) $@); \
>> then true; else exit 1; fi \

Syd> This just runs "make check" in the sub-directories, which will fail, right?
I checked the subdirectories - and it really should fail (and indeed does)

Syd> Should be

Syd>                  if (echo "Making in $$dir"; cd $$dir && $(MAKE) test); \

Yes, that works.  I've just run make;make check and it's fine with
this change.  Please commit this fix.

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.rhein-neckar.de

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]