This is the mail archive of the guile@sourceware.cygnus.com mailing list for the Guile project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

void * patch, updated




Hi,

I just updated my void * patch.  I made a silly mistake to leave some
debugging code in eval.c; I fixed it hopefully in the patch on my
homepage (~hanwen/software/guile-voidp).  It seems to work fine on my
machine.

Oh, BTW, I confirmed that the code for setting line numbers and column
numbers is buggy. Untested patch follows

	dokkum:~/pub-www$ guile
	guile>
	(set-port-column! (current-input-port) 0)
	ERROR: Bad memory access (Segmentation violation)
	ABORT: (signal)

--- guile-orig/libguile/ports.c Mon Feb 14 03:13:19 2000
+++ guile-test/libguile/ports.c Sat Feb 19 14:17:33 2000
@@ -1176,7 +1176,8 @@
   port = SCM_COERCE_OUTPORT (port);
   SCM_VALIDATE_OPENPORT (1,port);
   SCM_VALIDATE_INUM (2,line);
-  return SCM_PTAB_ENTRY (port)->line_number = SCM_INUM (line);
+  SCM_PTAB_ENTRY (port)->line_number = SCM_INUM (line);
+  return line;
 }
 #undef FUNC_NAME

@@ -1201,7 +1202,7 @@

 SCM_DEFINE (scm_set_port_column_x, "set-port-column!", 2, 0, 0,
             (SCM port, SCM column),
-           "@deffnx primitive set-port-line! [input-port] line\n"
+           "@deffnx primitive set-port-column! [input-port] column\n"
            "Set the current column or line number of
             @var{input-port}, using the\n"
            "current input port if none is specified.")
 #define FUNC_NAME s_scm_set_port_column_x
@@ -1209,7 +1210,8 @@
   port = SCM_COERCE_OUTPORT (port);
   SCM_VALIDATE_OPENPORT (1,port);
   SCM_VALIDATE_INUM (2,column);
-  return SCM_PTAB_ENTRY (port)->column_number = SCM_INUM (column);
+  SCM_PTAB_ENTRY (port)->column_number = SCM_INUM (column);
+  return column;
 }
 #undef FUNC_NAME




-- 

Han-Wen Nienhuys, hanwen@cs.uu.nl ** GNU LilyPond - The Music Typesetter 
      http://www.cs.uu.nl/people/hanwen/lilypond/index.html 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]