This is the mail archive of the guile@cygnus.com mailing list for the guile project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: dlsym leading underscore fixed

Tim Pierce <twp@skepsis.com> writes:

> 1997-11-21  Tim Pierce  <twp@twp.tezcat.com>
> 
> 	* acinclude.m4 (GUILE_DLSYM_USCORE): New macro, thanks Dan Hagerty
> 	<hag@ai.mit.edu>.
> 	* configure.in: Use it.
> 	* configure: Regenerated.
> 	* acconfig.h (DLSYM_ADDS_USCORE): New #define.

Many thanks for fixing the underscore problem!  But of course, I have
some nits to pick:

DLSYM_NEEDS_USCORE would be a better name, no?

libguile/ChangeLog talks about DLSYM_ADDS_UNDERSCORE, which is a typo,
I think.

sysdep_dynl_func now always copies the symbol string into fresh
storage, even if no changes need to be done to it.  Is this necessary?

The symbol string memory is not freed when an error is thrown (due to
unresolvable symbols, for example).