This is the mail archive of the gsl-discuss@sourceware.org mailing list for the GSL project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Help-gsl] Getting an extension listed on GSL page


Hi David, I'm moving this thread over to gsl-discuss from help-gsl.

I've been taking a look at your interp2d code since I'm currently doing some work which needs 2d interpolation. I like your coding style and think this should be moved into the repository at some point.

Just a few initial thoughts:

1. Your INDEX_2D macro for indexing the z array appears to use column-major ordering, even though the comment in the .h file says row-major. IE: it is currently defined as:

#define INDEX_2D(xi, yi, xsize, ysize) ((yi) * (xsize) + (xi))

which would store each column contiguously in memory instead of each row. The GSL gsl_matrix structure uses row-major ordering (see gsl_matrix_double.h):

283   return m->data[i * m->tda + j] ;

and so if a user wants to store their 2D grid in a gsl_matrix, its not straightforward to just pass m->data as the z array argument to your functions; they'd have to transpose first.

2. It would be really great if you could document your library with texinfo so when we fold the code into the repository the docs are ready to go. You can look at some other extensions for examples (ie see the doc/alf.texi file in the ALF extension)

Patrick

On 08/16/2013 05:09 PM, David Zaslavsky wrote:
Hi there,

For quite some time I've been working on a 2D interpolation library
compatible with the GSL. I've mentioned it a couple times on this list.
With some recent work it's gotten to the point where I consider it
ready for a first release. How would I go about getting it listed in the
"Extensions" section on the GSL web page?

Also if anyone would like to try compiling and running the test suite,
I'd appreciate knowing about any bugs that pop up. I've only tried it on
Linux with GCC 4.6.3.
  https://github.com/diazona/interp2d

:) David



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]