This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[glibc/fw/bug25097] (5 commits) Redefine _IO_iconv_t to store a single gconv step pointer [


The branch 'fw/bug25097' was updated to point to:

 96ab757... Redefine _IO_iconv_t to store a single gconv step pointer [

It previously pointed to:

 0b7470a... Redefine _IO_iconv_t to store a single gconv step pointer [

Diff:

!!! WARNING: THE FOLLOWING COMMITS ARE NO LONGER ACCESSIBLE (LOST):
-------------------------------------------------------------------

  0b7470a... Redefine _IO_iconv_t to store a single gconv step pointer [
  51ac7d6... slotinfo in struct dtv_slotinfo_list should be flexible arr
  6d24144... Avoid zero-length array at the end of struct link_map [BZ #
  7c0aae0... Introduce link_map_audit_state accessor function
  2cec33e... Properly initialize audit cookie for the dynamic loader [BZ

commit 0b7470af80bce3545e87c9dd7ff17423efc09cf4
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sun Nov 3 11:39:56 2019 +0100

    Redefine _IO_iconv_t to store a single gconv step pointer [BZ #25097]
    
    libio can only deal with gconv conversions which consist of a single
    step.  Not using __gconv_info simplifies the data structures somewhat.
    
    This eliminates a new GCC 10 warning about subscribing an inner
    zero-length array.
    
    Tested on x86_64-linux-gnu with mainline GCC.  Built with
    build-many-glibcs.py, also with mainline GCC.

commit 51ac7d6bf2e05053044b6fabe77bb80753deb80a
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sat Nov 2 17:03:06 2019 +0100

    slotinfo in struct dtv_slotinfo_list should be flexible array [BZ #25097]
    
    GCC 10 will warn about subscribing inner length zero arrays.  Use a GCC
    extension in csu/libc-tls.c to allocate space for the static_slotinfo
    variable.  Adjust nptl_db so that the type description machinery does
    not attempt to determine the size of the flexible array member slotinfo.

commit 6d241445b417089ac7d26976f520f35d3442abc0
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sun Nov 3 11:20:23 2019 +0100

    Avoid zero-length array at the end of struct link_map [BZ #25097]
    
    l_audit ends up as an internal array with _rtld_global, and GCC 10
    warns about this.
    
    This commit does not change the layout of _rtld_global, so it is
    suitable for backporting.  Future changes could allocate more of the
    audit state dynamically and remove it from always-allocated data
    structures, to optimize the common case of inactive auditing.

commit 7c0aae0bb37aa2682320eeeda6242c5946e072a8
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sat Nov 2 20:04:02 2019 +0100

    Introduce link_map_audit_state accessor function
    
    To improve GCC 10 compatibility, it is necessary to remove the l_audit
    zero-length array from the end of struct link_map.  In preparation of
    that, this commit introduces an accessor function for the audit state,
    so that it is possible to change the representation of the audit state
    without adjusting the code that accesses it.
    
    Tested on x86_64-linux-gnu.  Built in i686-gnu.

commit 2cec33e197910fad6109a0a79e65fcf2a794dcf2
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sat Nov 2 21:55:35 2019 +0100

    Properly initialize audit cookie for the dynamic loader [BZ #25157]
    
    The l_audit array is indexed by audit module, not audit function.
    
    Change-Id: I180eb3573dc1c57433750f5d8cb18271460ba5f2


Summary of changes (added commits):
-----------------------------------

  96ab757... Redefine _IO_iconv_t to store a single gconv step pointer [
  7591046... slotinfo in struct dtv_slotinfo_list should be flexible arr
  6a77162... Avoid zero-length array at the end of struct link_map [BZ #
  b1c595c... Introduce link_map_audit_state accessor function
  05efd60... Properly initialize audit cookie for the dynamic loader [BZ

commit 96ab757f9cd22bc880e0fcbe65a012c3726a9b87
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sun Nov 3 11:39:56 2019 +0100

    Redefine _IO_iconv_t to store a single gconv step pointer [BZ #25097]
    
    libio can only deal with gconv conversions which consist of a single
    step.  Not using __gconv_info simplifies the data structures somewhat.
    
    This eliminates a new GCC 10 warning about subscribing an inner
    zero-length array.
    
    Tested on x86_64-linux-gnu with mainline GCC.  Built with
    build-many-glibcs.py, also with mainline GCC.  Due to GCC PR 92039,
    there are failures left on 32-bit architectures with float128 support.
    
    Change-Id: I8b4c489b619a53154712ff32e1b6f13bb92d4203

commit 7591046cb1bf663525ed73229ab1ec03eb756326
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sat Nov 2 17:03:06 2019 +0100

    slotinfo in struct dtv_slotinfo_list should be flexible array [BZ #25097]
    
    GCC 10 will warn about subscribing inner length zero arrays.  Use a GCC
    extension in csu/libc-tls.c to allocate space for the static_slotinfo
    variable.  Adjust nptl_db so that the type description machinery does
    not attempt to determine the size of the flexible array member slotinfo.
    
    Change-Id: I51be146a7857186a4ede0bb40b332509487bdde8

commit 6a771621414cc85f218d6b13c204552afd0294c3
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sun Nov 3 11:20:23 2019 +0100

    Avoid zero-length array at the end of struct link_map [BZ #25097]
    
    l_audit ends up as an internal array with _rtld_global, and GCC 10
    warns about this.
    
    This commit does not change the layout of _rtld_global, so it is
    suitable for backporting.  Future changes could allocate more of the
    audit state dynamically and remove it from always-allocated data
    structures, to optimize the common case of inactive auditing.
    
    Change-Id: Ic911100730f9124d4ea977ead8e13cee64b84d45

commit b1c595cec06fabf65249a907db7d91e709ba6fd9
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sat Nov 2 20:04:02 2019 +0100

    Introduce link_map_audit_state accessor function
    
    To improve GCC 10 compatibility, it is necessary to remove the l_audit
    zero-length array from the end of struct link_map.  In preparation of
    that, this commit introduces an accessor function for the audit state,
    so that it is possible to change the representation of the audit state
    without adjusting the code that accesses it.
    
    Tested on x86_64-linux-gnu.  Built on i686-gnu.
    
    Change-Id: Id815673c29950fc011ae5301d7cde12624f658df

commit 05efd60143cf982e502054b6239907d91820c7b7
Author: Florian Weimer <fweimer@redhat.com>
Date:   Sat Nov 2 21:55:35 2019 +0100

    Properly initialize audit cookie for the dynamic loader [BZ #25157]
    
    The l_audit array is indexed by audit module, not audit function.
    
    Change-Id: I180eb3573dc1c57433750f5d8cb18271460ba5f2


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]