This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.29.9000-57-g86140c6
- From: jsm28 at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 13 Feb 2019 13:34:53 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.29.9000-57-g86140c6
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 86140c6223b5d14d773cf3050ffd0d14977c2c2d (commit)
from 16f87cfd630522afe745a0cf665287b8fe206cf4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=86140c6223b5d14d773cf3050ffd0d14977c2c2d
commit 86140c6223b5d14d773cf3050ffd0d14977c2c2d
Author: Joseph Myers <joseph@codesourcery.com>
Date: Wed Feb 13 13:34:24 2019 +0000
Avoid fall-through in test-container if execlp fails.
One of the implicit-fallthrough warnings from compiling glibc with
-Wextra appears to indicate an actual bug: the test-container code
could fall through inappropriately if execlp returns (which only
occurs on error). This patch adds appropriate error handling in this
case to avoid that fall-through.
Tested for x86_64.
* support/test-container.c (recursive_remove): Use FAIL_EXIT1 if
execlp returns.
diff --git a/ChangeLog b/ChangeLog
index 56f3007..4279eee 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2019-02-13 Joseph Myers <joseph@codesourcery.com>
+
+ * support/test-container.c (recursive_remove): Use FAIL_EXIT1 if
+ execlp returns.
+
2019-02-12 Wilco Dijkstra <wdijkstr@arm.com>
* benchtests/bench-strcasecmp.c (stupid_strcasecmp): Remove.
diff --git a/support/test-container.c b/support/test-container.c
index a24b24c..ed911e3 100644
--- a/support/test-container.c
+++ b/support/test-container.c
@@ -361,6 +361,7 @@ recursive_remove (char *path)
case 0:
/* Child. */
execlp ("rm", "rm", "-rf", path, NULL);
+ FAIL_EXIT1 ("exec rm: %m");
default:
/* Parent. */
waitpid (child, &status, 0);
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 5 +++++
support/test-container.c | 1 +
2 files changed, 6 insertions(+), 0 deletions(-)
hooks/post-receive
--
GNU C Library master sources