This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.28.9000-2-gc0e7e2c
- From: jsm28 at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 1 Aug 2018 11:19:36 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.28.9000-2-gc0e7e2c
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via c0e7e2c127cf6d90c4ba86be11b09f45530bf8be (commit)
from b029723b80eeb018cdc404e8972f6185c047522a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=c0e7e2c127cf6d90c4ba86be11b09f45530bf8be
commit c0e7e2c127cf6d90c4ba86be11b09f45530bf8be
Author: Joseph Myers <joseph@codesourcery.com>
Date: Wed Aug 1 11:18:57 2018 +0000
Move SNAN_TESTS_TYPE_CAST out of math-tests.h.
The math-tests.h header has many different macros and groups of
macros, defined using #ifndef in the generic version which is included
by architecture versions with #include_next after possibly defining
non-default versions of some of those macros.
This use of #ifndef is contrary to our normal typo-proof conventions
for macro definitions. This patch moves one of the macros,
SNAN_TESTS_TYPE_CAST, out to its own sysdeps header, to follow those
typo-proof conventions more closely.
Tested with build-many-glibcs.py.
2018-08-01 Joseph Myers <joseph@codesourcery.com>
* sysdeps/generic/math-tests-snan-cast.h: New file.
* sysdeps/powerpc/math-tests-snan-cast.h: Likewise.
* sysdeps/generic/math-tests.h: Include <math-tests-snan-cast.h>.
(SNAN_TESTS_TYPE_CAST): Do not define macro here.
* sysdeps/powerpc/math-tests.h (SNAN_TESTS_TYPE_CAST): Likewise.
diff --git a/ChangeLog b/ChangeLog
index f9e8b7e..d0ac705 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2018-08-01 Joseph Myers <joseph@codesourcery.com>
+
+ * sysdeps/generic/math-tests-snan-cast.h: New file.
+ * sysdeps/powerpc/math-tests-snan-cast.h: Likewise.
+ * sysdeps/generic/math-tests.h: Include <math-tests-snan-cast.h>.
+ (SNAN_TESTS_TYPE_CAST): Do not define macro here.
+ * sysdeps/powerpc/math-tests.h (SNAN_TESTS_TYPE_CAST): Likewise.
+
2018-08-01 Carlos O'Donel <carlos@redhat.com>
* version.h (RELEASE): Set to "development".
diff --git a/sysdeps/powerpc/math-tests.h b/sysdeps/generic/math-tests-snan-cast.h
similarity index 54%
copy from sysdeps/powerpc/math-tests.h
copy to sysdeps/generic/math-tests-snan-cast.h
index cf8adcc..ff64c1c 100644
--- a/sysdeps/powerpc/math-tests.h
+++ b/sysdeps/generic/math-tests-snan-cast.h
@@ -1,4 +1,4 @@
-/* Configuration for math tests. PowerPC version.
+/* Configuration for math tests: casts of sNaN values. Generic version.
Copyright (C) 2013-2018 Free Software Foundation, Inc.
This file is part of the GNU C Library.
@@ -16,18 +16,11 @@
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
-/* On PowerPC, in versions of GCC up to at least 4.7.2, a type cast -- which is
- a IEEE 754-2008 general-computational convertFormat operation (IEEE
- 754-2008, 5.4.2) -- does not turn a sNaN into a qNaN (whilst raising an
- INVALID exception), which is contrary to IEEE 754-2008 5.1 and 7.2. This
- renders certain tests infeasible in this scenario.
- <http://gcc.gnu.org/PR56828>. */
-#define SNAN_TESTS_TYPE_CAST 0
+#ifndef _MATH_TESTS_SNAN_CAST_H
+#define _MATH_TESTS_SNAN_CAST_H 1
-#ifndef __NO_FPRS__
-/* Setting exception flags in FPSCR results in enabled traps for those
- exceptions being taken. */
-# define EXCEPTION_SET_FORCES_TRAP 1
-#endif
+/* Indicate whether to run tests involving type casts of sNaN values.
+ These are run unless overridden. */
+#define SNAN_TESTS_TYPE_CAST 1
-#include_next <math-tests.h>
+#endif /* math-tests-snan-cast.h. */
diff --git a/sysdeps/generic/math-tests.h b/sysdeps/generic/math-tests.h
index cf9eff4..8f5f806 100644
--- a/sysdeps/generic/math-tests.h
+++ b/sysdeps/generic/math-tests.h
@@ -52,12 +52,6 @@
/* Return nonzero value if to run tests involving sNaN values for X. */
#define SNAN_TESTS(x) MATH_TESTS_TG (SNAN_TESTS_, , x)
-/* Indicate whether to run tests involving type casts of sNaN values. These
- are run unless overridden. */
-#ifndef SNAN_TESTS_TYPE_CAST
-# define SNAN_TESTS_TYPE_CAST 1
-#endif
-
/* Indicate whether operations on signaling NaNs preserve the payload
(if possible; it is not possible with a zero payload if the high
bit is set for signaling NaNs) when generating a quiet NaN, and
@@ -122,3 +116,5 @@
#ifndef EXCEPTION_SET_FORCES_TRAP
# define EXCEPTION_SET_FORCES_TRAP 0
#endif
+
+#include <math-tests-snan-cast.h>
diff --git a/sysdeps/powerpc/math-tests.h b/sysdeps/powerpc/math-tests-snan-cast.h
similarity index 60%
copy from sysdeps/powerpc/math-tests.h
copy to sysdeps/powerpc/math-tests-snan-cast.h
index cf8adcc..13e941d 100644
--- a/sysdeps/powerpc/math-tests.h
+++ b/sysdeps/powerpc/math-tests-snan-cast.h
@@ -1,4 +1,4 @@
-/* Configuration for math tests. PowerPC version.
+/* Configuration for math tests: casts of sNaN values. PowerPC version.
Copyright (C) 2013-2018 Free Software Foundation, Inc.
This file is part of the GNU C Library.
@@ -16,18 +16,15 @@
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
-/* On PowerPC, in versions of GCC up to at least 4.7.2, a type cast -- which is
- a IEEE 754-2008 general-computational convertFormat operation (IEEE
- 754-2008, 5.4.2) -- does not turn a sNaN into a qNaN (whilst raising an
- INVALID exception), which is contrary to IEEE 754-2008 5.1 and 7.2. This
- renders certain tests infeasible in this scenario.
- <http://gcc.gnu.org/PR56828>. */
-#define SNAN_TESTS_TYPE_CAST 0
+#ifndef POWERPC_MATH_TESTS_SNAN_CAST_H
+#define POWERPC_MATH_TESTS_SNAN_CAST_H 1
-#ifndef __NO_FPRS__
-/* Setting exception flags in FPSCR results in enabled traps for those
- exceptions being taken. */
-# define EXCEPTION_SET_FORCES_TRAP 1
-#endif
+/* On PowerPC, in versions of GCC up to at least 4.7.2, a type cast --
+ which is a IEEE 754-2008 general-computational convertFormat
+ operation (IEEE 754-2008, 5.4.2) -- does not turn a sNaN into a
+ qNaN (whilst raising an INVALID exception), which is contrary to
+ IEEE 754-2008 5.1 and 7.2. This renders certain tests infeasible
+ in this scenario. <https://gcc.gnu.org/PR56828>. */
+#define SNAN_TESTS_TYPE_CAST 0
-#include_next <math-tests.h>
+#endif /* math-tests-snan-cast.h. */
diff --git a/sysdeps/powerpc/math-tests.h b/sysdeps/powerpc/math-tests.h
index cf8adcc..f95428a 100644
--- a/sysdeps/powerpc/math-tests.h
+++ b/sysdeps/powerpc/math-tests.h
@@ -16,14 +16,6 @@
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
-/* On PowerPC, in versions of GCC up to at least 4.7.2, a type cast -- which is
- a IEEE 754-2008 general-computational convertFormat operation (IEEE
- 754-2008, 5.4.2) -- does not turn a sNaN into a qNaN (whilst raising an
- INVALID exception), which is contrary to IEEE 754-2008 5.1 and 7.2. This
- renders certain tests infeasible in this scenario.
- <http://gcc.gnu.org/PR56828>. */
-#define SNAN_TESTS_TYPE_CAST 0
-
#ifndef __NO_FPRS__
/* Setting exception flags in FPSCR results in enabled traps for those
exceptions being taken. */
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 8 ++++++
.../generic/math-tests-snan-cast.h | 15 ++++++-----
sysdeps/generic/math-tests.h | 8 +----
.../{math-tests.h => math-tests-snan-cast.h} | 25 ++++++++-----------
sysdeps/powerpc/math-tests.h | 8 ------
5 files changed, 29 insertions(+), 35 deletions(-)
copy dlfcn/bug-dl-leaf.c => sysdeps/generic/math-tests-snan-cast.h (71%)
copy sysdeps/powerpc/{math-tests.h => math-tests-snan-cast.h} (60%)
hooks/post-receive
--
GNU C Library master sources