This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.27.9000-326-g0085be1
- From: stli at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 19 Apr 2018 10:48:21 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.27.9000-326-g0085be1
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 0085be1415a38b40a5a1a12e49368498f1687380 (commit)
via da796524f8d64df3113e3c538adf285cf3ba041c (commit)
from f55a4fdefb00837f2e2a77c04792e69e888ead3e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=0085be1415a38b40a5a1a12e49368498f1687380
commit 0085be1415a38b40a5a1a12e49368498f1687380
Author: Stefan Liebler <stli@linux.vnet.ibm.com>
Date: Thu Apr 19 12:38:37 2018 +0200
Disable lock elision for mutex pretty printer tests.
If e.g. the testcase nptl/test-mutex-printers is run
with enabled lock-elision, it fails on s390x with:
Error: Response does not match the expected pattern.
Command: print *mutex
Expected pattern: pthread_mutex_t
Response: No symbol "mutex" in current context.
(gdb)
See https://www.sourceware.org/ml/libc-alpha/2018-03/msg00583.html
for more details.
In fact the mutex pretty printer tests rely on looking at the
internal details of the lock, thus we disable it by setting up
the GLIB_TUNABLES environment variable inside gdb.
ChangeLog:
* scripts/test_printers_common.py (init_test): Disable lock elision.
diff --git a/ChangeLog b/ChangeLog
index df941db..5cc4dc9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
2018-04-19 Stefan Liebler <stli@linux.vnet.ibm.com>
+ * scripts/test_printers_common.py (init_test): Disable lock elision.
+
+2018-04-19 Stefan Liebler <stli@linux.vnet.ibm.com>
+
* math/test-tgmath.c (count_double, count_float,
count_ldouble, count_cdouble, count_cfloat,
count_cldouble): Use volatile int.
diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py
index 73ca525..cf4de5a 100644
--- a/scripts/test_printers_common.py
+++ b/scripts/test_printers_common.py
@@ -171,6 +171,9 @@ def init_test(test_bin, printer_files, printer_names):
# Finally, load the test binary.
test('file {0}'.format(test_bin))
+ # Disable lock elision.
+ test('set environment GLIBC_TUNABLES glibc.elision.enable=0')
+
def go_to_main():
"""Executes a gdb 'start' command, which takes us to main."""
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=da796524f8d64df3113e3c538adf285cf3ba041c
commit da796524f8d64df3113e3c538adf285cf3ba041c
Author: Stefan Liebler <stli@linux.vnet.ibm.com>
Date: Thu Apr 19 12:32:50 2018 +0200
Use volatile global counters in test-tgmath.c.
If build with -Os on s390x, the test-tgmath fails with:
float functions not called often enough (-10000)
Within compile_testf(), the counter (count_float) is saved
before the complex functions are called.
Afterwards the saved counter differs to the current-counter.
But the tests with the complex functions do not increment count_float!
Instead count_float is saved to a register before calling totalorder
and totalordermag which both increment count_float.
The compiler is allowed to do that as totalorderf and totalordermagf
is declared with __attribute__ ((__const__)) in math/bits/mathcalls.h.
Thus this patch adjusts the global counters to be volatile.
Then count_float is saved after totalordermag.
ChangeLog:
* math/test-tgmath.c (count_double, count_float,
count_ldouble, count_cdouble, count_cfloat,
count_cldouble): Use volatile int.
diff --git a/ChangeLog b/ChangeLog
index ec19da4..df941db 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2018-04-19 Stefan Liebler <stli@linux.vnet.ibm.com>
+
+ * math/test-tgmath.c (count_double, count_float,
+ count_ldouble, count_cdouble, count_cfloat,
+ count_cldouble): Use volatile int.
+
2018-04-19 Samuel Thibault <samuel.thibault@ens-lyon.org>
* sysdeps/mach/hurd/i386/Makefile [$(subdir) = conform]
diff --git a/math/test-tgmath.c b/math/test-tgmath.c
index 6d8e7fd..2b0787c 100644
--- a/math/test-tgmath.c
+++ b/math/test-tgmath.c
@@ -45,12 +45,12 @@ complex float fz;
complex double dz;
complex long double lz;
-int count_double;
-int count_float;
-int count_ldouble;
-int count_cdouble;
-int count_cfloat;
-int count_cldouble;
+volatile int count_double;
+volatile int count_float;
+volatile int count_ldouble;
+volatile int count_cdouble;
+volatile int count_cfloat;
+volatile int count_cldouble;
#define NCALLS 134
#define NCALLS_INT 4
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 10 ++++++++++
math/test-tgmath.c | 12 ++++++------
scripts/test_printers_common.py | 3 +++
3 files changed, 19 insertions(+), 6 deletions(-)
hooks/post-receive
--
GNU C Library master sources