This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.19-221-g6da3618
- From: schwab at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 25 Mar 2014 14:36:35 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.19-221-g6da3618
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 6da36183eeb86e5cbd29b8281180d56352284ad2 (commit)
from 449282f2e0e850c29f6a9666058503d4734964f0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=6da36183eeb86e5cbd29b8281180d56352284ad2
commit 6da36183eeb86e5cbd29b8281180d56352284ad2
Author: Andreas Schwab <schwab@suse.de>
Date: Tue Mar 25 08:51:59 2014 +0100
Fix use of uninitialized variable
diff --git a/ChangeLog b/ChangeLog
index ef2263e..40a00c5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-03-25 Andreas Schwab <schwab@suse.de>
+
+ * sysdeps/unix/sysv/linux/check_pf.c (make_request): Add out_fail2
+ label to be used after in6ailist is initialized.
+
2014-03-20 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
* nptl/sysdeps/unix/sysv/linux/s390/bits/pthreadtypes.h
diff --git a/sysdeps/unix/sysv/linux/check_pf.c b/sysdeps/unix/sysv/linux/check_pf.c
index 6d8468d..e6a12ed 100644
--- a/sysdeps/unix/sysv/linux/check_pf.c
+++ b/sysdeps/unix/sysv/linux/check_pf.c
@@ -182,10 +182,10 @@ make_request (int fd, pid_t pid)
ssize_t read_len = TEMP_FAILURE_RETRY (__recvmsg (fd, &msg, 0));
if (read_len < 0)
- goto out_fail;
+ goto out_fail2;
if (msg.msg_flags & MSG_TRUNC)
- goto out_fail;
+ goto out_fail2;
struct nlmsghdr *nlmh;
for (nlmh = (struct nlmsghdr *) buf;
@@ -251,7 +251,7 @@ make_request (int fd, pid_t pid)
{
newp = malloc (sizeof (*newp));
if (newp == NULL)
- goto out_fail;
+ goto out_fail2;
newp->use_malloc = true;
}
newp->info.flags = (((ifam->ifa_flags
@@ -289,7 +289,7 @@ make_request (int fd, pid_t pid)
result = malloc (sizeof (*result)
+ in6ailistlen * sizeof (struct in6addrinfo));
if (result == NULL)
- goto out_fail;
+ goto out_fail2;
result->timestamp = get_nl_timestamp ();
result->usecnt = 2;
@@ -319,7 +319,7 @@ make_request (int fd, pid_t pid)
free (buf);
return result;
- out_fail:
+ out_fail2:
while (in6ailist != NULL)
{
struct in6ailist *next = in6ailist->next;
@@ -327,6 +327,7 @@ make_request (int fd, pid_t pid)
free (in6ailist);
in6ailist = next;
}
+ out_fail:
if (use_malloc)
free (buf);
return NULL;
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 5 +++++
sysdeps/unix/sysv/linux/check_pf.c | 11 ++++++-----
2 files changed, 11 insertions(+), 5 deletions(-)
hooks/post-receive
--
GNU C Library master sources