This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch, ibm/2.13/master, updated. glibc-2.13-29-g86a0020


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, ibm/2.13/master has been updated
       via  86a00204ac4492964771c1f1a10b0dec1444ba31 (commit)
      from  51f3cf36c1fc25ce2f2d932e087f29e8db19354c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sources.redhat.com/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=86a00204ac4492964771c1f1a10b0dec1444ba31

commit 86a00204ac4492964771c1f1a10b0dec1444ba31
Author: ryanarn <ryanarn@igoo.rchland.ibm.com>
Date:   Fri Jul 1 09:42:21 2011 -0500

    Remove pthread_attr_setstacksize from __aio_create_helper_thread.
    (cherry picked from commit 2c3d9ba9a332cecb009b97ebac5bb78a13118c7c)

diff --git a/ChangeLog b/ChangeLog
index d04fb83..8237364 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-06-30  Ryan S. Arnold  <rsa@linux.vnet.ibm.com>
+
+	* nptl/sysdeps/unix/sysv/linux/aio_misc.h
+	(__aio_create_helper_thread): Remove call to
+	pthread_attr_setstacksize () which set the stacksize to
+	PTHREAD_STACK_MIN.  This is too small if large amounts of TLS are in
+	use.  Removing this call effectively sets stacksize to 'default'.
+
 2011-06-28  Adhemerval Zanella  <azanella@linux.vnet.ibm.com>
 
 	* sysdeps/powerpc/fpu/e_hypot.c: optimizations for POWER5 and POWER6.
diff --git a/nptl/sysdeps/unix/sysv/linux/aio_misc.h b/nptl/sysdeps/unix/sysv/linux/aio_misc.h
index 406d96e..2bf7c17 100644
--- a/nptl/sysdeps/unix/sysv/linux/aio_misc.h
+++ b/nptl/sysdeps/unix/sysv/linux/aio_misc.h
@@ -46,8 +46,8 @@ __aio_create_helper_thread (pthread_t *threadp, void *(*tf) (void *),
   pthread_attr_init (&attr);
   pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED);
 
-  /* The helper thread needs only very little resources.  */
-  (void) pthread_attr_setstacksize (&attr, PTHREAD_STACK_MIN);
+  /* Don't set the stacksize to PTHREAD_STACK_MIN.  Let it default, otherwise
+     the stack may be too small if TLS is in use.  */
 
   /* Block all signals in the helper thread.  To do this thoroughly we
      temporarily have to block all signals here.  */

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                               |    8 ++++++++
 nptl/sysdeps/unix/sysv/linux/aio_misc.h |    4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]