[Bug build/23990] New: test-container error out on failure to exec child.

["carlos at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=23990

            Bug ID: 23990
           Summary: test-container error out on failure to exec child.
           Product: glibc
           Version: 2.30
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: carlos at redhat dot com
                CC: carlos at redhat dot com
  Target Milestone: ---

It's possible the execlp fails in support/test-contianer.c (recursive_remove).

 366   child = fork ();
 367 
 368   switch (child) {
 369   case -1:
 370     perror("fork");
 371     FAIL_EXIT1 ("Unable to fork");
 372   case 0:
 373     /* Child.  */
 374     execlp ("rm", "rm", "-rf", path, NULL);

This should FAIL_EXIT1 like above?

 375   default:
 376     /* Parent.  */
 377     waitpid (child, &status, 0);
 378     /* "rm" would have already printed a suitable error message.  */
 379     if (! WIFEXITED (status)
 380         || WEXITSTATUS (status) != 0)
 381       exit (1);
 382 
 383     break;

We don't want to continue after a child fails to exec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.