[Bug dynamic-link/23467] x86/CET: A property note parser bug

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=23467

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  98864ed0e055583707e37cdb7d41a9cdeac4473b (commit)
      from  c92a00d865638cebcfd13cfe0c3e811f565fe43b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=98864ed0e055583707e37cdb7d41a9cdeac4473b

commit 98864ed0e055583707e37cdb7d41a9cdeac4473b
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Jul 30 16:14:46 2018 -0700

    x86/CET: Fix property note parser [BZ #23467]

    GNU_PROPERTY_X86_FEATURE_1_AND may not be the first property item.  We
    need to check each property item until we reach the end of the property
    or find GNU_PROPERTY_X86_FEATURE_1_AND.

    This patch adds 2 tests.  The first test checks if IBT is enabled and
    the second test reads the output from the first test to check if IBT
    is is enabled.  The second second test fails if IBT isn't enabled
    properly.

    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

        [BZ #23467]
        * sysdeps/unix/sysv/linux/x86/Makefile (tests): Add
        tst-cet-property-1 and tst-cet-property-2 if CET is enabled.
        (CFLAGS-tst-cet-property-1.o): New.
        (ASFLAGS-tst-cet-property-dep-2.o): Likewise.
        ($(objpfx)tst-cet-property-2): Likewise.
        ($(objpfx)tst-cet-property-2.out): Likewise.
        * sysdeps/unix/sysv/linux/x86/tst-cet-property-1.c: New file.
        * sysdeps/unix/sysv/linux/x86/tst-cet-property-2.c: Likewise.
        * sysdeps/unix/sysv/linux/x86/tst-cet-property-dep-2.S: Likewise.
        * sysdeps/x86/dl-prop.h (_dl_process_cet_property_note): Parse
        each property item until GNU_PROPERTY_X86_FEATURE_1_AND is found.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   15 +++++
 sysdeps/unix/sysv/linux/x86/Makefile               |   15 +++++
 sysdeps/unix/sysv/linux/x86/tst-cet-property-1.c   |   44 ++++++++++++++
 sysdeps/unix/sysv/linux/x86/tst-cet-property-2.c   |   63 ++++++++++++++++++++
 .../unix/sysv/linux/x86/tst-cet-property-dep-2.S   |   63 ++++++++++++++++++++
 sysdeps/x86/dl-prop.h                              |   29 ++++++---
 6 files changed, 220 insertions(+), 9 deletions(-)
 create mode 100644 sysdeps/unix/sysv/linux/x86/tst-cet-property-1.c
 create mode 100644 sysdeps/unix/sysv/linux/x86/tst-cet-property-2.c
 create mode 100644 sysdeps/unix/sysv/linux/x86/tst-cet-property-dep-2.S

-- 
You are receiving this mail because:
You are on the CC list for the bug.