This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/23459] COMMON_CPUID_INDEX_80000001 isn't populated for Intel processors


https://sourceware.org/bugzilla/show_bug.cgi?id=23459

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, release/2.27/master has been updated
       via  2dab17550dd464bcf531088efa81a9d595167f2a (commit)
       via  a452341529ef0a952b576e20d3c7e3c48dcb8427 (commit)
      from  8623cfe300b4fe88e8b7343bb15829bfe4317609 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=2dab17550dd464bcf531088efa81a9d595167f2a

commit 2dab17550dd464bcf531088efa81a9d595167f2a
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Jul 29 06:08:59 2018 -0700

    x86: Populate COMMON_CPUID_INDEX_80000001 for Intel CPUs [BZ #23459]

    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

        [BZ #23459]
        * sysdeps/x86/cpu-features.c (get_extended_indices): New
        function.
        (init_cpu_features): Call get_extended_indices for both Intel
        and AMD CPUs.
        * sysdeps/x86/cpu-features.h (COMMON_CPUID_INDEX_80000001):
        Remove "for AMD" comment.

    (cherry picked from commit be525a69a6630abc83144c0a96474f2e26da7443)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a452341529ef0a952b576e20d3c7e3c48dcb8427

commit a452341529ef0a952b576e20d3c7e3c48dcb8427
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Jul 29 06:08:59 2018 -0700

    x86: Correct index_cpu_LZCNT [BZ #23456]

    cpu-features.h has

     #define bit_cpu_LZCNT              (1 << 5)
     #define index_cpu_LZCNT    COMMON_CPUID_INDEX_1
     #define reg_LZCNT

    But the LZCNT feature bit is in COMMON_CPUID_INDEX_80000001:

    Initial EAX Value: 80000001H
    ECX Extended Processor Signature and Feature Bits:
    Bit 05: LZCNT available

    index_cpu_LZCNT should be COMMON_CPUID_INDEX_80000001, not
    COMMON_CPUID_INDEX_1.  The VMX feature bit is in COMMON_CPUID_INDEX_1:

    Initial EAX Value: 01H
    Feature Information Returned in the ECX Register:
    5 VMX

    Reviewed-by: Carlos O'Donell <carlos@redhat.com>

        [BZ #23456]
        * sysdeps/x86/cpu-features.h (index_cpu_LZCNT): Set to
        COMMON_CPUID_INDEX_80000001.

    (cherry picked from commit 65d87ade1ee6f3ac099105e3511bd09bdc24cf3f)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                  |   16 ++++++++++++++++
 NEWS                       |    2 ++
 sysdeps/x86/cpu-features.c |   27 ++++++++++++++++++---------
 sysdeps/x86/cpu-features.h |    4 ++--
 4 files changed, 38 insertions(+), 11 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]