[Bug libc/16552] Unify umount implementations in terms of umount2

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=16552

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5f45f96ad09d7f80172b45dca16d6ca2baeea2a8 (commit)
      from  3dfd23eb4bdc7707048b115548e2238dacef064e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5f45f96ad09d7f80172b45dca16d6ca2baeea2a8

commit 5f45f96ad09d7f80172b45dca16d6ca2baeea2a8
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon Mar 26 21:18:28 2018 +0000

    Unify umount function implementations (bug 16552).

    Linux kernel architectures have various arrangements for umount
    syscalls.  There is a syscall that takes flags, and an older one that
    does not.  Newer architectures have only the one taking flags, under
    the name umount2 (or under the name umount, in the ia64 case).  Older
    architectures may have both, under the names umount2 and umount (or
    under the names umount and oldumount, in the alpha case).  glibc then
    has several similar implementations of the umount function (no flags)
    in terms of either the __umount2 function, or the corresponding
    syscall, or in terms of the old syscall under either of its names.

    This patch simplifies the implementations in glibc by always using the
    __umount2 function to implement the umount function on all systems
    using the Linux kernel.  The linux/generic implementation is moved to
    sysdeps/unix/sysv/linux (without any changes to code or comments) and
    all the other variants are removed.  (This will have the effect of
    causing the new syscall to be used in some cases that previously used
    the old one, but as discussed for previous changes, such a change to
    the underlying syscalls used is OK.)

    There remain two variants of how the __umount2 function is
    implemented, either in umount2.S, or, for ia64, in syscalls.list.

    Tested with build-many-glibcs.py.

        [BZ #16552]
        * sysdeps/unix/sysv/linux/generic/umount.c: Move to ....
        * sysdeps/unix/sysv/linux/umount.c: ... here.
        * sysdeps/unix/sysv/linux/arm/umount.c: Remove file.
        * sysdeps/unix/sysv/linux/hppa/umount.c: Likewise.
        * sysdeps/unix/sysv/linux/ia64/umount.c: Likewise.
        * sysdeps/unix/sysv/linux/mips/mips64/umount.c: Likewise.
        * sysdeps/unix/sysv/linux/powerpc/powerpc64/umount.c: Likewise.
        * sysdeps/unix/sysv/linux/umount.S: Likewise.
        * sysdeps/unix/sysv/linux/x86_64/umount.c: Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   13 ++++++++
 sysdeps/unix/sysv/linux/arm/umount.c               |   30 --------------------
 sysdeps/unix/sysv/linux/hppa/umount.c              |    1 -
 sysdeps/unix/sysv/linux/ia64/umount.c              |   29 -------------------
 sysdeps/unix/sysv/linux/mips/mips64/umount.c       |   30 --------------------
 sysdeps/unix/sysv/linux/powerpc/powerpc64/umount.c |    1 -
 sysdeps/unix/sysv/linux/umount.S                   |   12 --------
 sysdeps/unix/sysv/linux/{generic => }/umount.c     |    0
 sysdeps/unix/sysv/linux/x86_64/umount.c            |   30 --------------------
 9 files changed, 13 insertions(+), 133 deletions(-)
 delete mode 100644 sysdeps/unix/sysv/linux/arm/umount.c
 delete mode 100644 sysdeps/unix/sysv/linux/hppa/umount.c
 delete mode 100644 sysdeps/unix/sysv/linux/ia64/umount.c
 delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/umount.c
 delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/umount.c
 delete mode 100644 sysdeps/unix/sysv/linux/umount.S
 rename sysdeps/unix/sysv/linux/{generic => }/umount.c (100%)
 delete mode 100644 sysdeps/unix/sysv/linux/x86_64/umount.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.