This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug math/22987] [powerpc/sparc] fdim inlines errno, exceptions handling
- From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sourceware dot org
- Date: Tue, 20 Mar 2018 18:37:01 +0000
- Subject: [Bug math/22987] [powerpc/sparc] fdim inlines errno, exceptions handling
- Auto-submitted: auto-generated
- References: <bug-22987-131@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=22987
--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via d0c5d731af73fcd787fb398a34e2431bcb686bd3 (commit)
from 8a07b0c43c46a480da070efd53a2720195e2256f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d0c5d731af73fcd787fb398a34e2431bcb686bd3
commit d0c5d731af73fcd787fb398a34e2431bcb686bd3
Author: Joseph Myers <joseph@codesourcery.com>
Date: Tue Mar 20 18:35:50 2018 +0000
Remove powerpc, sparc fdim inlines (bug 22987).
The powerpc and sparc bits/mathinline.h include inlines of fdim and
fdimf. These are not restricted to -fno-math-errno, but do not set
errno, and wrongly use ordered <= comparisons instead of the required
islessequal comparisons (this latter issue is latent on powerpc
because GCC wrongly uses unordered comparison instructions for
operations that should use ordered comparison instructions).
Since we wish to avoid such header inlines anyway, leaving it to the
compiler to inline such standard functions under appropriate
conditions, this patch fixes those issues by removing the inlines in
question (and thus removing the sparc bits/mathinline.h header which
had no other inlines left in it). I've filed
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85003> for adding
correct fdim inlines to GCC, since the function is simple enough that
a correct inline is a perfectly reasonable architecture-independent
optimization with -fno-math-errno and in the absence of implicit
excess precision.
Tested with build-many-glibcs.py for all its powerpc and sparc
configurations.
[BZ #22987]
* sysdeps/powerpc/bits/mathinline.h (fdim): Remove inline
function.
(fdimf): Likewise.
* sysdeps/sparc/fpu/bits/mathinline.h: Remove file.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 6 ++++
sysdeps/powerpc/bits/mathinline.h | 14 --------
sysdeps/sparc/fpu/bits/mathinline.h | 57 -----------------------------------
3 files changed, 6 insertions(+), 71 deletions(-)
delete mode 100644 sysdeps/sparc/fpu/bits/mathinline.h
--
You are receiving this mail because:
You are on the CC list for the bug.