This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug build/22792] tcb-offsets.h dependency dropped


https://sourceware.org/bugzilla/show_bug.cgi?id=22792

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  f5d1f629c693bc30ccc8ff1246cb37986c1adb1c (commit)
      from  54412d20618b7b93f136a168e788573575f8a7a6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f5d1f629c693bc30ccc8ff1246cb37986c1adb1c

commit f5d1f629c693bc30ccc8ff1246cb37986c1adb1c
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Feb 23 11:29:27 2018 -0800

    Define GEN_AS_CONST_HEADERS when generating header files [BZ #22792]

    Glibc build generates header files to define constants from special .sym
    files.  If a .sym file includes the same header file which it generates,
    it leads to circular dependency which may lead to build hang on a
    many-core machine.  Define GEN_AS_CONST_HEADERS when generating header
    files to avoid circular dependency.

    <tcb-offsets.h> is needed for i686 and it isn't needed for x86-64 at
    least since glibc 2.23.

    Tested on i686 and x86-64.

        [BZ #22792]
        * Makerules ($(common-objpfx)%.h): Pass -DGEN_AS_CONST_HEADERS
        to $(CC).
        * sysdeps/unix/sysv/linux/i386/lowlevellock.h: Include
        <tcb-offsets.h> only if GEN_AS_CONST_HEADERS isn't defined.
        * sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Don't include
        <tcb-offsets.h>.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                     |   10 ++++++++++
 Makerules                                     |    9 ++++++++-
 sysdeps/unix/sysv/linux/i386/lowlevellock.h   |    9 ++++++++-
 sysdeps/unix/sysv/linux/x86_64/lowlevellock.h |    1 -
 4 files changed, 26 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]