This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/15105] Extra PLT references with -Os


https://sourceware.org/bugzilla/show_bug.cgi?id=15105

--- Comment #13 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  30ac923dbe7d0c16df8a368150ecd736557508f4 (commit)
      from  7ec5f9465e732e668d0dc94ac078ba68056d6d0a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=30ac923dbe7d0c16df8a368150ecd736557508f4

commit 30ac923dbe7d0c16df8a368150ecd736557508f4
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Feb 21 18:01:11 2018 +0000

    Fix -Os getc_unlocked linknamespace, localplt issues (bug 15105, bug
19463).

    Continuing the fixes for linknamespace and localplt test failures with
    -Os that arise from functions not being inlined in that case, this
    patch fixes such failures for getc_unlocked.

    __getc_unlocked already exists; this patch makes it explicitly hidden,
    calls it where needed for namespace reasons, adds an inline function
    for it when inline functions are used and adds libc_hidden_proto /
    libc_hidden_weak for getc_unlocked.

    Tested for x86_64 (both without -Os to make sure that case continues
    to work, and with -Os to make sure all the relevant linknamespace and
    localplt test failures are resolved).  Because of other such failures
    that remain after this patch, neither of the bugs can yet be closed.

        [BZ #15105]
        [BZ #19463]
        * libio/getc_u.c (getc_unlocked): Use libc_hidden_weak.
        * include/stdio.h [!_ISOMAC] (__getc_unlocked): Use
        attribute_hidden, and define inline if [__USE_EXTERN_INLINES].
        [!_ISOMAC] (getc_unlocked): Use libc_hidden_proto.
        * misc/getttyent.c (__getttyent): Call __getc_unlocked instead of
        getc_unlocked.
        * time/tzfile.c (__tzfile_read): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        |   12 ++++++++++++
 include/stdio.h  |    9 ++++++++-
 libio/getc_u.c   |    1 +
 misc/getttyent.c |    2 +-
 time/tzfile.c    |   12 ++++++------
 5 files changed, 28 insertions(+), 8 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]