This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/20829] crypt snprintf namespace


https://sourceware.org/bugzilla/show_bug.cgi?id=20829

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  61158ffa9a17476d88aaf4a833d13b12f1c51387 (commit)
      from  7773556dfb2bf62f7b6deda66fa3821a3bcdbf3e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=61158ffa9a17476d88aaf4a833d13b12f1c51387

commit 61158ffa9a17476d88aaf4a833d13b12f1c51387
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Nov 16 22:46:48 2016 +0000

    Fix crypt snprintf namespace (bug 20829).

    Extending linknamespace tests to cover libcrypt showed that crypt
    brings in references to snprintf, but is in XPG3 and XPG4 which don't
    have snprintf.  This patch fixes it to use __snprintf instead,
    exporting __snprintf from libc.so at version GLIBC_PRIVATE and adding
    libc_hidden_proto / libc_hidden_def accordingly.

    Tested for x86_64 and x86, in conjunction with the testsuite changes
    to enable linknamespace testing for libdl and libcrypt.  Also tested
    (compilation only) for powerpc to make sure there were no problem
    interactions with the optional-long-double handling for snprintf.

        [BZ #20829]
        * stdio-common/Versions (__snprintf): Add to version
        GLIBC_PRIVATE.
        * include/stdio.h (__snprintf): Use libc_hidden_proto.
        * stdio-common/snprintf.c (__snprintf): Use libc_hidden_def.
        * crypt/sha256-crypt.c (__sha256_crypt_r): Use __snprintf instead
        of snprintf.
        * crypt/sha512-crypt.c (__sha512_crypt_r): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog               |   11 +++++++++++
 crypt/sha256-crypt.c    |    4 ++--
 crypt/sha512-crypt.c    |    4 ++--
 include/stdio.h         |    1 +
 stdio-common/Versions   |    2 ++
 stdio-common/snprintf.c |    1 +
 6 files changed, 19 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]