This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug stdio/20014] stdio.h namespace for pre-threads POSIX


https://sourceware.org/bugzilla/show_bug.cgi?id=20014

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  a7657f3012765b9c2d80c7387d487fc5156d3bc2 (commit)
      from  022d239b5d20df6c0b1ee05d527b94b671a746fb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a7657f3012765b9c2d80c7387d487fc5156d3bc2

commit a7657f3012765b9c2d80c7387d487fc5156d3bc2
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Apr 28 22:01:04 2016 +0000

    Fix stdio.h namespace for pre-threads POSIX (bug 20014).

    stdio.h declares flockfile, ftrylockfile, funlockfile, getc_unlocked,
    getchar_unlocked, putc_unlocked and putchar_unlocked if __USE_POSIX,
    with comments "These are defined in POSIX.1:1996.".  But __USE_POSIX
    is actually POSIX.1:1990, and these functions should not be declared
    for 1990 / 1992 / 1993 POSIX, XPG3 or XPG4.  This patch fixes stdio.h
    to use __USE_POSIX199506 instead for those conditionals, as that is
    the correct conditional for the version of POSIX that introduced
    threads, and with threads those functions.

    Tested for x86_64 and x86 (testsuite, and that installed shared
    libraries are unchanged by the patch).

        [BZ #20014]
        * libio/stdio.h (getc_unlocked): Declare if [__USE_POSIX199506],
        not [__USE_POSIX].
        (getchar_unlocked): Likewise.
        (putc_unlocked): Likewise.
        (putchar_unlocked): Likewise.
        (flockfile): Likewise.
        (ftrylockfile): Likewise.
        (funlockfile): Likewise.
        * conform/Makefile (test-xfail-XPG3/stdio.h/conform): Remove
        variable.
        (test-xfail-XPG4/stdio.h/conform): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        |   13 +++++++++++++
 conform/Makefile |    2 --
 libio/stdio.h    |    6 +++---
 3 files changed, 16 insertions(+), 5 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]