[Bug libc/19137] i386/epoll_pwait.S doesn't support cancellation

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19137

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, hjl/i386/master has been created
        at  92fc2b21d5cd2a43c5d19039bf4d6dcb5a60487b (commit)

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=92fc2b21d5cd2a43c5d19039bf4d6dcb5a60487b

commit 92fc2b21d5cd2a43c5d19039bf4d6dcb5a60487b
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Aug 12 12:10:06 2015 -0700

    Remove i386/epoll_pwait.S

    Only i386 implements epoll_pwait in assembly code withot cancellation
    support.  All other architectures implement epoll_pwait in epoll_pwait.c
    with

    int epoll_pwait (int epfd, struct epoll_event *events,
                 int maxevents, int timeout,
                 const sigset_t *set)
    {
      return SYSCALL_CANCEL (epoll_pwait, epfd, events, maxevents,
                         timeout, set, _NSIG / 8);
    }

    Although there is no test for epoll_pwait in glibc, since SYSCALL_CANCEL
    works on i386 and epoll_pwait.c works for other architectures, it is
    safe to assume that epoll_pwait.c with SYSCALL_CANCEL also works on
    i386.

        [BZ #19137]
        * sysdeps/unix/sysv/linux/i386/Makefile (CFLAGS-epoll_pwait.c):
        Add -fomit-frame-pointer.
        * sysdeps/unix/sysv/linux/i386/epoll_pwait.S: Remove file.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=442b784c73520eeb1814fd94c972e8a40feee86c

commit 442b784c73520eeb1814fd94c972e8a40feee86c
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Aug 21 14:46:05 2015 -0700

    Avoid reading errno in syscall implementations

    Reading errno is expensive for x86 PIC.  With INTERNAL_SYSCALL,
    INTERNAL_SYSCALL_ERROR_P, INTERNAL_SYSCALL_ERRNO and
    INLINE_SYSCALL_ERROR_RETURN_VALUE, we can avoid reading errno.

        * sysdeps/unix/sysv/linux/eventfd.c (eventfd): Use
        INTERNAL_SYSCALL, INTERNAL_SYSCALL_ERROR_P and
        INTERNAL_SYSCALL_ERRNO to avoid reading errno.
        * sysdeps/unix/sysv/linux/fstatfs64.c (__fstatfs64): Likewise.
        * sysdeps/unix/sysv/linux/getrlimit64.c (__getrlimit64):
        Likewise.
        * sysdeps/unix/sysv/linux/setrlimit64.c (setrlimit64):
        Likewise.
        * sysdeps/unix/sysv/linux/signalfd.c (signalfd): Likewise.
        * sysdeps/unix/sysv/linux/statfs64.c (__statfs64): Likewise.

-----------------------------------------------------------------------

-- 
You are receiving this mail because:
You are on the CC list for the bug.