[Bug libc/18544] mq_notify pthread_barrier_* namespace

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18544

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  90dd591393a03d023be06a33acfb42c1b328b0fa (commit)
      from  45dcd79f6eb37ad4e9e6967f1d459ffc3629eb1f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=90dd591393a03d023be06a33acfb42c1b328b0fa

commit 90dd591393a03d023be06a33acfb42c1b328b0fa
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Wed Jun 17 20:16:56 2015 +0000

    Fix mq_notify pthread_barrier_* namespace (bug 18544).

    mq_notify (present in POSIX by 1996) brings in references to
    pthread_barrier_init and pthread_barrier_wait (new in the 2001 edition
    of POSIX).  This patch fixes this by making those functions into weak
    aliases of __pthread_barrier_*, exporting the __pthread_barrier_*
    names at version GLIBC_PRIVATE and using them in mq_notify.

    Tested for x86_64 and x86 (testsuite, and comparison of installed
    stripped shared libraries).  Changes in addresses from dynamic symbol
    table / PLT changes render most comparisons not particularly useful,
    but when the addresses of subsequent code don't change there's no sign
    of unexpected changes there.  This patch does not remove any
    linknamespace XFAILs because of other namespace issues remaining with
    mqueue.h functions.

        [BZ #18544]
        * nptl/pthread_barrier_init.c (pthread_barrier_init): Rename to
        __pthread_barrier_init and define as weak alias of
        __pthread_barrier_init.
        * sysdeps/sparc/nptl/pthread_barrier_init.c
        (pthread_barrier_init): Likewise.
        * nptl/pthread_barrier_wait.c (pthread_barrier_wait): Rename to
        __pthread_barrier_wait and define as weak alias of
        __pthread_barrier_wait.
        * sysdeps/sparc/nptl/pthread_barrier_wait.c
        (pthread_barrier_wait): Likewise.
        * sysdeps/sparc/sparc32/pthread_barrier_wait.c
        (pthread_barrier_wait): Likewise.
        * sysdeps/unix/sysv/linux/i386/i486/pthread_barrier_wait.S
        (pthread_barrier_wait): Likewise.
        * sysdeps/unix/sysv/linux/x86_64/pthread_barrier_wait.S
        (pthread_barrier_wait): Likewise.
        * nptl/Versions (libpthread): Export __pthread_barrier_init and
        __pthread_barrier_wait at version GLIBC_PRIVATE.
        * include/pthread.h (__pthread_barrier_init): Declare.
        (__pthread_barrier_wait): Likewise.
        * sysdeps/unix/sysv/linux/mq_notify.c (notification_function):
        Call __pthread_barrier_wait instead of pthread_barrier_wait.
        (helper_thread): Likewise.
        (init_mq_netlink): Call __pthread_barrier_init instead of
        pthread_barrier_init.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   27 ++++++++++++++++++++
 NEWS                                               |    2 +-
 include/pthread.h                                  |   10 +++++++
 nptl/Versions                                      |    1 +
 nptl/pthread_barrier_init.c                        |    3 +-
 nptl/pthread_barrier_wait.c                        |    3 +-
 sysdeps/sparc/nptl/pthread_barrier_init.c          |    3 +-
 sysdeps/sparc/nptl/pthread_barrier_wait.c          |    3 +-
 sysdeps/sparc/sparc32/pthread_barrier_wait.c       |    3 +-
 .../sysv/linux/i386/i486/pthread_barrier_wait.S    |    9 +++---
 sysdeps/unix/sysv/linux/mq_notify.c                |    6 ++--
 .../unix/sysv/linux/x86_64/pthread_barrier_wait.S  |    9 +++---
 12 files changed, 62 insertions(+), 17 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.