[Bug build/15915] Erroneous implied make rule for linkobj/libc.so in Makerules

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

http://sourceware.org/bugzilla/show_bug.cgi?id=15915

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, ibm/2.18/master has been updated
       via  052b65bfeee78d8ba82f070f9f10f79bb0de5376 (commit)
      from  7d000197af0d94220c665c5a655c8575fa348e47 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=052b65bfeee78d8ba82f070f9f10f79bb0de5376

commit 052b65bfeee78d8ba82f070f9f10f79bb0de5376
Author: Brooks Moses <bmoses@google.com>
Date:   Tue Feb 18 11:18:44 2014 -0600

    Fix erroneous (and circular) implied pattern rule for linkobj/libc.so.

    [BZ #15915] As described in the bug, the pattern rule for lib%.so files
    in Makerules includes linkobj/libc.so as a dependency.  However, the
    explicit rule for linkobj/libc.so is in the top-level Makefile.

    Thus, the subdirectory makefiles that include Makerules end up with an
    erroneous makefile pattern rule for linkobj/libc.so that includes
    itself as a dependency.  The result is make warnings whenever rules
    for other .so files are resolved -- and, on occasion, actual makefile
    failures when a race condition causes the implicit rule to actually be
    used.

    This patch moves the explicit rules for linkobj/libc.so into Makerules
    to clear up this problem.  It also elaborates a couple of comments
    that I'd initially found confusing.

    Backport of 5f855e3598a576c35e54623a13b256f3e87fcd4d

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog |    6 ++++++
 Makefile  |   25 +------------------------
 Makerules |   37 ++++++++++++++++++++++++++++++++++---
 NEWS      |    4 ++--
 4 files changed, 43 insertions(+), 29 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.