This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug manual/14347] New: LOG_MAKEPRI needs LOG_FAC, or should not shift
- From: "rasmus.villemoes at decode dot is" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sources dot redhat dot com
- Date: Tue, 10 Jul 2012 15:55:22 +0000
- Subject: [Bug manual/14347] New: LOG_MAKEPRI needs LOG_FAC, or should not shift
- Auto-submitted: auto-generated
http://sourceware.org/bugzilla/show_bug.cgi?id=14347
Bug #: 14347
Summary: LOG_MAKEPRI needs LOG_FAC, or should not shift
Product: glibc
Version: 2.16
Status: NEW
Severity: minor
Priority: P2
Component: manual
AssignedTo: unassigned@sourceware.org
ReportedBy: rasmus.villemoes@decode.is
CC: mtk.manpages@gmail.com, roland@gnu.org
Classification: Unclassified
The two examples of use of the LOG_MAKEPRI macro in the manual for 2.16 (and
earlier) are broken. The facility macros LOG_USER, ..., LOG_LOCAL1, ... already
contain a left-shift of 3, so to use these macros in LOG_MAKEPRI (which also
makes a shift), that shift has to be undone by using the LOG_FAC macro. The
example at the end of 18.2.2 would then be something like
syslog (LOG_MAKEPRI(LOG_FAC(LOG_LOCAL1), LOG_ERROR),
"Unable to make network connection to %s. Error=%m", host);
Alternatively, the documentation could drop mentioning the LOG_MAKEPRI macro at
all and simply instruct people to OR the facility and priority, resulting in
the much simpler
syslog (LOG_LOCAL1 | LOG_ERROR,
"Unable to make network connection to %s. Error=%m", host);
(Alternatively, this is a bug against the LOG_MAKEPRI macro, which should
simply do exactly this, but this would break code which uses the LOG_FAC
macro.)
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.