[Bug nscd/5112] nscd segfaults when forking for paranoia mode when not caching all requests

["bldewolf at csupomona dot edu" <sourceware-bugzilla at sourceware dot org>]

------- Additional Comments From bldewolf at csupomona dot edu  2008-01-17 21:42 -------
Why was this fixed in such a bizarre manner that caused the conditional to be
inverted?  I believe the correct fix is to factor out the duplicated code in
connections.c and nscd.c into a function that is called in both situations.  At
the very least, connections.c should have been fixed in the manner of my patch,
such that the two code blocks in connections.c and nscd.c remained identical, so
it is obvious that they do the same thing.

Creating a new function for this purpose should have been done the first time
someone copied this block of code, and I think it should be done before these
two functionally equivalent blocks begin to look less and less alike despite
their identical purpose.  It can only get worse as time passes, if bugs are
found in one and not the other (as has happened here), or the functionality is
copied elsewhere again and there becomes three unrelated places where fixes
would have to go.

Please consider making these changes, as I think it would help prevent future
missed bugs such as this one.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=5112

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.