This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: patchwork.sourceware.org is live!
- From: Andreas Jaeger <aj at suse dot com>
- To: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, gdb at sourceware dot org, carlos at redhat dot com, fche at redhat dot com, gbenson at redhat dot com
- Date: Mon, 26 May 2014 10:02:22 +0200
- Subject: Re: patchwork.sourceware.org is live!
- Authentication-results: sourceware.org; auth=none
- References: <20140523211338 dot GK12497 at spoyarek dot pnq dot redhat dot com> <5382E7F2 dot 4020506 at suse dot com> <CAAHN_R0zVp8B7zXfARzvKvETx9kLZp1FYPN9pUWDwV4cNCjCvA at mail dot gmail dot com> <5382EF22 dot 4060705 at suse dot com> <CAAHN_R0GhZvqUDEN7e3DS2Y7b7W752oJabgET-nu6Oq8LJaeTA at mail dot gmail dot com>
On 05/26/2014 09:52 AM, Siddhesh Poyarekar wrote:
> On 26 May 2014 13:07, Andreas Jaeger <aj@suse.com> wrote:
>>
>> What happens if one person says "fine" while another one disagrees? Is
>> Accepted then the right state for this?
>
> The first reviewer sets 'Accepted' (assuming she doesn't need another
> reviewer to validate) and if another reviewer disagrees then he can
> set the status back to 'Under Review'. if he agrees, then there's no
> need to change any status.
>
>> Could you write up a workflow: Live of a patch, something like:
>> 1. Patch gets submitted, system puts patch into state NEW
>> 2. Reviewer comments on it:
>> a) Disagrees: Sets it to
>> b) agrees: Sets it to
>> c) Not a patch for glibc, set it to Not Applicable
>> 3. Patch gets committed: Set it to Commited/Accepted
>
> That's a good idea. I have modified the current document[1] and also
> added the Committed status to the document. Once we have consensus on
> adding the new 'Committed' status, I'll also add it to patchwork.
>
> Siddhesh
> [1] https://sourceware.org/glibc/wiki/Patch%20Review%20Workflow
>
thanks, that answers my current ;) questions nicely,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix ImendÃrffer,HRB16746 (AG NÃrnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126