This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: Patchwork patch tracking system
- From: Siva Chandra <sivachandra at google dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Eric Christopher <echristo at gmail dot com>, Gary Benson <gbenson at redhat dot com>, Stan Shebs <stanshebs at earthlink dot net>, "gdb at sourceware dot org" <gdb at sourceware dot org>
- Date: Tue, 22 Apr 2014 11:37:37 -0700
- Subject: Re: Patchwork patch tracking system
- Authentication-results: sourceware.org; auth=none
- References: <20140402100842 dot GA956 at blade dot nx> <533F3713 dot 40700 at earthlink dot net> <20140417135040 dot GA891 at blade dot nx> <20140422130652 dot GG5790 at adacore dot com> <CALehDX6F9wMzSMF2iA-UdGnOTSxpj6uywbad84Uy=HmBnu88Gw at mail dot gmail dot com> <20140422155132 dot GB6383 at adacore dot com>
On Tue, Apr 22, 2014 at 8:51 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> FWIW we (some of the google folk) looked at geritt for LLVM and
>> discarded in favor of phabricator. It seemed to solve a lot of the
>> problems that we had and allowed communication to and from the mailing
>> lists for patches which was key for us as we have a similar review
>> style to gcc/gdb/binutils. We didn't want to remove the ability for
>> people to send patches to the mailing lists, but yet get a better
>> review mechanism for large patches/queuing/etc.
>
> Thanks for the suggestion! I have to say, from the outside,
> phabricator looks like a pretty interesting option.
I am essentially an outsider here, and I have not used phabricator.
However, the Chromium project uses Rietveld for codereview:
https://code.google.com/p/rietveld/ and
https://codereview.chromium.org/
IIRC, Diego Novillo setup a rietveld instance for GCC:
http://gcc.gnu.org/wiki/rietveld
Chromium-OS project uses gerrit and hence I have used both these tools
and my personal choice is rietveld over gerrit by many a mile.
Rietveld can be configured to send mails to a watchlist for every
patch sent out for review and also for every review posting. Hence,
all review logs can still be saved in a mailing list archive.
Thanks,
Siva Chandra