This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] GDB testsuite patch.

From: Michael Chastain <mec dot gnu at mindspring dot com>
To: manjo at austin dot ibm dot com, drow at false dot org
Cc: gdb at sources dot redhat dot com
Date: Wed, 25 Aug 2004 09:48:45 -0400
Subject: Re: [RFC] GDB testsuite patch.
References: <Pine.LNX.4.58.0408191014360.21237@lazy><41251A45.nail58D215HD7@mindspring.com><Pine.LNX.4.58.0408191637370.21237@lazy><4125BB8B.nailJWP1FZGHJ@mindspring.com><Pine.LNX.4.58.0408242319060.7065@lazy><20040825124945.GA25217@nevyn.them.org>

Daniel Jacobowitz <drow@false.org> wrote:
> That's not the same as what you've done.  gdb_file_cmd should not
> always fail for objects without debugging information, since there are
> other tests that work OK without it.  This only applies to the gdb.gdb/
> tests.

Damn, I noticed this, but I got so caught up in the procedural criticism,
I forgot to mention it.

Daniel is right; gdb_file_cmd is not a good place to test for this
unconditionally.  You have to look in gdb.gdb/*.exp and find a good
way so that you make this check only for gdb.gdb/*.exp.

Michael

References:
- gdb.gdb/ testcase issues.
  - From: Manoj Iyer
- Re: gdb.gdb/ testcase issues.
  - From: Michael Chastain
- Re: gdb.gdb/ testcase issues.
  - From: Manoj Iyer
- Re: gdb.gdb/ testcase issues.
  - From: Michael Chastain
- [RFC] GDB testsuite patch.
  - From: Manoj Iyer
- Re: [RFC] GDB testsuite patch.
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]