This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Thu, 26 Sep 2002, Eli Zaretskii wrote: > + fd = open (name, O_RDONLY); > + if (fd < 0) > + return 0; > > This `open' call should use a binary mode (O_BINARY or'ed with O_RDONLY). > > + debug_file_search_path = xstrdup (DEBUGDIR); > + c = add_set_cmd ("debug-file-search-path", class_support, var_string, > + (char *) &debug_file_search_path, > + "Set the search path for loading separate debug symbols.\n" > + "Separate debug symbols are first searched for in the same\n" > + "directory as the binary, then in the .debug subdirectory,\n" > + "and lastly at the path of the directory of the binary with\n" > + "the global debug-file search path prepended\n", > + &setlist); > > Isn't the use of ``search-path'' here confusing? The variable holds a > name of a single directory, not a colon-separated list of directories, > right? If so, shouldn't we call it ``debug-file-directory'' or some such? > > Finally, this new feature should be documented in the manual. (Sorry if > you already posted the patch for that and I forgot.) Ok. Fixed these in the attached patch. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander Larsson Red Hat, Inc alexl@redhat.com alla@lysator.liu.se He's a fiendish misogynist gangster who dotes on his loving old ma. She's a ditzy cigar-chomping mercenary with a knack for trouble. They fight crime!
Attachment:
gdb_debug4.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |