This is the mail archive of the
gdb@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] Re: The problem with stabs and sign extension
On Wed, Aug 08, 2001 at 05:16:16PM -0700, Daniel Jacobowitz wrote:
>
> There's actually a clear bug here, once you know where to look. A
> CORE_ADDR is assigned to a long int in partial-stab.h. There's a
> warning flag in GCC for this, isn't there?
>
You miised one CORE_ADDR in partial-stab.h. This patch seems to fix
my problem. Any comments?
Thanks.
H.J.
-----
2001-08-10 Daniel Jacobowitz <drow@mvista.com>
H.J. Lu (hjl@gnu.org)
* partial-stab.h: valu should be a CORE_ADDR.
2001-08-08 H.J. Lu (hjl@gnu.org)
* dbxread.c (SWAP_SYMBOL): Removed.
(INTERNALIZE_SYMBOL): Check sign extended vma.
--- gdb/dbxread.c.vma Fri Jul 13 12:12:34 2001
+++ gdb/dbxread.c Wed Aug 8 21:02:29 2001
@@ -946,22 +946,15 @@ fill_symbuf (bfd *sym_bfd)
symbuf_read += nbytes;
}
-#define SWAP_SYMBOL(symp, abfd) \
- { \
- (symp)->n_strx = bfd_h_get_32(abfd, \
- (unsigned char *)&(symp)->n_strx); \
- (symp)->n_desc = bfd_h_get_16 (abfd, \
- (unsigned char *)&(symp)->n_desc); \
- (symp)->n_value = bfd_h_get_32 (abfd, \
- (unsigned char *)&(symp)->n_value); \
- }
-
#define INTERNALIZE_SYMBOL(intern, extern, abfd) \
{ \
(intern).n_type = bfd_h_get_8 (abfd, (extern)->e_type); \
(intern).n_strx = bfd_h_get_32 (abfd, (extern)->e_strx); \
(intern).n_desc = bfd_h_get_16 (abfd, (extern)->e_desc); \
- (intern).n_value = bfd_h_get_32 (abfd, (extern)->e_value); \
+ if (bfd_get_sign_extend_vma (abfd)) \
+ (intern).n_value = bfd_h_get_signed_32 (abfd, (extern)->e_value); \
+ else \
+ (intern).n_value = bfd_h_get_32 (abfd, (extern)->e_value); \
}
/* Invariant: The symbol pointed to by symbuf_idx is the first one
--- gdb/partial-stab.h.vma Fri Jul 13 12:12:54 2001
+++ gdb/partial-stab.h Fri Aug 10 15:25:10 2001
@@ -201,7 +201,7 @@ switch (CUR_SYMBOL_TYPE)
case N_SO:
{
- unsigned long valu;
+ CORE_ADDR valu;
static int prev_so_symnum = -10;
static int first_so_symnum;
char *p;
@@ -399,7 +399,7 @@ switch (CUR_SYMBOL_TYPE)
/* See if this is an end of function stab. */
if (pst && CUR_SYMBOL_TYPE == N_FUN && *namestring == '\000')
{
- unsigned long valu;
+ CORE_ADDR valu;
/* It's value is the size (in bytes) of the function for
function relative stabs, or the address of the function's