This is the mail archive of the gdb@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Linuxthreads patch for gdb 5.0?


On Mon, Apr 03, 2000 at 09:30:52PM +0200, Mark Kettenis wrote:
>    Date: Mon, 3 Apr 2000 10:47:07 -0700
>    From: "H . J . Lu" <hjl@valinux.com>
> 
>    What happened to my patch:
> 
>    http://sourceware.cygnus.com/ml/gdb-patches/2000-q1/msg00567.html
> 
>    Without it, I got 35 threads failures under Linux/ia32 with
>    "make check". With my patch, I got 0 threads failures.
> 
> I think there was still some hope that the lin-thread.c code could be
> fixed before the 5.0 release.
> 
> The reason for the failures you're seeing is *not* related to problems
> in the lin-thread.c code per se, but the fact that glibc 2.1.3 for
> Linux/ia32 was released with the wrong typedef for prfpregset_t in
> <sys/procfs.h> (and this still isn't fixed).  I think the fact that
> things are so horribly broken on the most important platform using the
> lin-thread.c code is enough justification for adding your patch.
> 

Thanks.

> You didn't address my concerns about the unused LIN_THREADS_CFLAGS
> variable though.  Could you please remove it and resubmit your patch?
> 

You can take LIN_THREADS_CFLAGS out when you check it in. I don't
have the time to send in another patch unless I can check it in
myself.


-- 
H.J. Lu (hjl@gnu.org)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]