This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix regression caused by minimal symbol changes
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Mon, 18 Mar 2019 19:59:09 -0400
- Subject: [binutils-gdb] Fix regression caused by minimal symbol changes
*** TEST RESULTS FOR COMMIT 4bd56d18cc9799f283715a96ba61fd4b958b2f71 ***
Author: Tom Tromey <tromey@adacore.com>
Branch: master
Commit: 4bd56d18cc9799f283715a96ba61fd4b958b2f71
Fix regression caused by minimal symbol changes
The earlier patch to change minimal symbol allocations to use xmalloc
erroneously left a call to obstack_blank in
minimal_symbol_reader::install. Because obstack_blank does not finish
the object allocation on an obstack, this in turn could cause invalid
memory reads in some situations.
This patch fixes the problem by removing the call. Tested on x86-64
Fedora 29; also verified with valgrind.
gdb/ChangeLog
2019-03-18 Tom Tromey <tromey@adacore.com>
* minsyms.c (minimal_symbol_reader::install): Remove call to
obstack_blank.