This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb/gdb-8.3-branch] Fix scrolling right in the TUI
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Mon, 18 Mar 2019 11:12:08 -0400
- Subject: [binutils-gdb/gdb-8.3-branch] Fix scrolling right in the TUI
*** TEST RESULTS FOR COMMIT 6885905d1da17780b3f00f90e9b56340a7f239e8 ***
Author: Hannes Domani <ssbssa@yahoo.de>
Branch: gdb-8.3-branch
Commit: 6885905d1da17780b3f00f90e9b56340a7f239e8
Fix scrolling right in the TUI
This commit fixes two issues in scrolling right in the TUI:
#1 - Scrolling right with the arrow keys, the first keypress doesn't
do anything. The problem is that copy_source_line() checks if
(column < first_col), and because of the ++column directly before, it
basically starts with 1 instead of 0.
#2 - Scrolling right handles TABS and escaped characters as single
characters, which just looks weird. The problem is that there's a
spot that misses handling TABS.
gdb/ChangeLog:
2019-03-18 Hannes Domani <ssbssa@yahoo.de>
* tui/tui-source.c (copy_source_line): Fix handling of 'column'.
Handle tabs.
- Follow-Ups:
- Failures on RHEL-s390x-m64, branch gdb-8.3-branch
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch gdb-8.3-branch
- Failures on Debian-s390x-native-gdbserver-m64, branch gdb-8.3-branch
- Failures on Debian-s390x-m64, branch gdb-8.3-branch
- Failures on Fedora-i686, branch gdb-8.3-branch
- Failures on Fedora-x86_64-cc-with-index, branch gdb-8.3-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch gdb-8.3-branch
- Failures on Fedora-x86_64-native-gdbserver-m64, branch gdb-8.3-branch
- Failures on Fedora-x86_64-m64, branch gdb-8.3-branch
- Failures on Fedora-x86_64-m32, branch gdb-8.3-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch gdb-8.3-branch
- Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-8.3-branch