This is the mail archive of the
mailing list for the GDB project.
[binutils-gdb] Binutils: Always skip only 1 byte for CIE version 1's return address register.
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Fri, 01 Mar 2019 07:46:28 -0500
- Subject: [binutils-gdb] Binutils: Always skip only 1 byte for CIE version 1's return address register.
*** TEST RESULTS FOR COMMIT 4ffd290906608e72fd98d627a24aa2c2b6ecf4ce ***
Author: Tamar Christina <email@example.com>
Binutils: Always skip only 1 byte for CIE version 1's return address register.
According to the specification for the CIE entries, when the CIE version is 1 then
the return address register field is always 1 byte. Readelf does this correctly in
read_cie in dwarf.c but ld does this incorrectly and always tries to read a
skip_leb128. If the value here has the top bit set then ld will incorrectly read
at least another byte, causing either an assert failure or an incorrect address to
be used in eh_frame.
I'm not sure how to generate a generic test for this as I'd need to write assembly,
and it's a bit hard to trigger. Essentially the relocated value needs to start with
something that & 0x70 != 0x10 while trying to write a personality.
* elf-eh-frame.c (_bfd_elf_write_section_eh_frame): Correct CIE parse.