This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] OBVIOUS Use report_unrecognized_option_error in 'demangle' and 'info macro' commands.
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Sat, 27 Oct 2018 15:46:42 -0400
- Subject: [binutils-gdb] OBVIOUS Use report_unrecognized_option_error in 'demangle' and 'info macro' commands.
*** TEST RESULTS FOR COMMIT cd948f5b2be612b784591dbe438dc518f6b80d61 ***
Author: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Branch: master
Commit: cd948f5b2be612b784591dbe438dc518f6b80d61
OBVIOUS Use report_unrecognized_option_error in 'demangle' and 'info macro' commands.
Rather than have some local logic to throw an error for an unrecognized option,
use the new cli-utils.h function throwing an error.
At the same time, fix some wrong indentation in info_macro_command
and fix a small bug in 'demangle' error handling:
Without the patch:
(gdb) demangle -L c++ abcd
Unrecognized option 'c++' to demangle command. Try "help demangle".
(gdb)
With the patch:
(gdb) demangle -L c++ abcd
Unrecognized option '-L' to demangle command. Try "help demangle".
2018-10-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* macrocmd.c (info_macro_command): Use report_unrecognized_option_error
to report a bad option and fix indentation.
* demangle.c (demangle_command): Use report_unrecognized_option_error
to report a bad option and correctly report the bad option.
- Follow-Ups:
- *** COMPILATION FAILED *** Failures on Solaris11-sparcv9-m64, branch master *** BREAKAGE ***
- *** COMPILATION FAILED *** Failures on Solaris11-amd64-m64, branch master *** BREAKAGE ***
- Failures on Fedora-s390x-m64, branch master
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch master
- Failures on Debian-s390x-m64, branch master
- Failures on Fedora-i686, branch master
- *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE ***
- Failures on Fedora-x86_64-m64, branch master
- Failures on Fedora-x86_64-m32, branch master
- Failures on Fedora-x86_64-cc-with-index, branch master
- Failures on Ubuntu-Aarch64-m64, branch master