This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Removing lookup_minimal_symbol_and_objfile
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Mon, 17 Sep 2018 05:27:25 -0400
- Subject: [binutils-gdb] Removing lookup_minimal_symbol_and_objfile
*** TEST RESULTS FOR COMMIT 64cc34d87089ff24b43e0a8760be132b7afa6f34 ***
Author: Weimin Pan <weimin.pan@oracle.com>
Branch: master
Commit: 64cc34d87089ff24b43e0a8760be132b7afa6f34
Removing lookup_minimal_symbol_and_objfile
Function lookup_minimal_symbol_and_objfile iterates on all objfiles and
calls lookup_minimal_symbol for each of them, effectively searching in all
objfiles. lookup_bound_minimal_symbol calls lookup_minimal_symbol with NULL,
which also effectively searches all objfiles. AFAIK, they do exactly the same
thing, so we can get rid of one (and lookup_minimal_symbol_and_objfile happens
to be the most inefficient because it ends up n^2 on the number of objfiles).
Tested in both aarch64-linux-gnu and amd64-linux-gnu. No regressions.