This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb/gdb-8.1-branch] Unset gdbarch significant_addr_bit by default
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Wed, 30 May 2018 23:55:14 -0400
- Subject: [binutils-gdb/gdb-8.1-branch] Unset gdbarch significant_addr_bit by default
*** TEST RESULTS FOR COMMIT 8679931c2c9f97ad182f8f0a9e8fab20305719b5 ***
Author: Omair Javaid <omair.javaid@linaro.org>
Branch: gdb-8.1-branch
Commit: 8679931c2c9f97ad182f8f0a9e8fab20305719b5
Unset gdbarch significant_addr_bit by default
This patch fixes a bug introduced by fix to AArch64 pointer tagging.
In our fix for tagged pointer support our agreed approach was to sign
extend user-space address after clearing tag bits. This is not same
for all architectures and this patch allows sign extension for
addresses on targets which specifically set significant_addr_bit.
More information about patch that caused the issues and discussion
around tagged pointer support can be found in links below:
https://sourceware.org/ml/gdb-patches/2018-05/msg00000.html
https://sourceware.org/ml/gdb-patches/2017-12/msg00159.html
gdb/ChangeLog:
2018-05-31 Omair Javaid <omair.javaid@linaro.org>
PR gdb/23210
* gdbarch.sh (significant_addr_bit): Default to zero when
not set by target architecture.
* gdbarch.c: Re-generated.
* utils.c (address_significant): Update.
- Follow-Ups:
- Failures on Fedora-s390x-m64, branch gdb-8.1-branch
- Failures on RHEL-s390x-m64, branch gdb-8.1-branch
- Failures on Debian-s390x-m64, branch gdb-8.1-branch
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch gdb-8.1-branch
- Failures on Debian-s390x-native-gdbserver-m64, branch gdb-8.1-branch
- Failures on Fedora-i686, branch gdb-8.1-branch
- Failures on Fedora-x86_64-native-gdbserver-m64, branch gdb-8.1-branch
- Failures on Fedora-x86_64-cc-with-index, branch gdb-8.1-branch
- Failures on Fedora-x86_64-m64, branch gdb-8.1-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch gdb-8.1-branch