This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb/gdb-8.1-branch] gdbserver/Windows: crash during connection establishment phase
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Thu, 10 May 2018 15:32:04 -0400
- Subject: [binutils-gdb/gdb-8.1-branch] gdbserver/Windows: crash during connection establishment phase
*** TEST RESULTS FOR COMMIT 572797ce5f4dc697120cfd07e95553118b4f105e ***
Author: Joel Brobecker <brobecker@adacore.com>
Branch: gdb-8.1-branch
Commit: 572797ce5f4dc697120cfd07e95553118b4f105e
gdbserver/Windows: crash during connection establishment phase
On Windows, starting a new process with GDBserver seems to work,
in the sense that the program does get started, and GDBserver
confirms that it is listening for GDB to connect. However, as soon as
GDB establishes the connection with GDBserver, and starts discussing
with it, GDBserver crashes, with a SEGV.
This SEGV occurs in remote-utils.c::prepare_resume_reply...
| regp = current_target_desc ()->expedite_regs;
| [...]
| while (*regp)
... because, in our case, REGP is NULL.
This patches fixes the issues by adding a parameter to init_target_desc,
in order to make sure that we always provide the list of registers when
we initialize a target description.
gdb/ChangeLog:
PR server/23158:
* regformats/regdat.sh: Adjust script, following the addition
of the new expedite_regs parameter to init_target_desc.
gdb/gdbserver/ChangeLog:
PR server/23158:
* tdesc.h (init_target_desc) <expedite_regs>: New parameter.
* tdesc.c (init_target_desc) <expedite_regs>: New parameter.
Use it to set the expedite_regs field in the given tdesc.
* x86-tdesc.h: New file.
* linux-aarch64-tdesc.c (aarch64_linux_read_description):
Adjust following the addition of the new expedite_regs parameter
to init_target_desc.
* linux-tic6x-low.c (tic6x_read_description): Likewise.
* linux-x86-tdesc.c: #include "x86-tdesc.h".
(i386_linux_read_description, amd64_linux_read_description):
Adjust following the addition of the new expedite_regs parameter
to init_target_desc.
* lynx-i386-low.c: #include "x86-tdesc.h".
(lynx_i386_arch_setup): Adjust following the addition of the new
expedite_regs parameter to init_target_desc.
* nto-x86-low.c: #include "x86-tdesc.h".
(nto_x86_arch_setup): Adjust following the addition of the new
expedite_regs parameter to init_target_desc.
* win32-i386-low.c: #include "x86-tdesc.h".
(i386_arch_setup): Adjust following the addition of the new
expedite_regs parameter to init_target_desc.
- Follow-Ups:
- Failures on Fedora-s390x-m64, branch gdb-8.1-branch
- Failures on RHEL-s390x-m64, branch gdb-8.1-branch
- Failures on Debian-s390x-m64, branch gdb-8.1-branch
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch gdb-8.1-branch
- Failures on Debian-s390x-native-gdbserver-m64, branch gdb-8.1-branch
- Failures on Fedora-x86_64-m64, branch gdb-8.1-branch
- Failures on Fedora-i686, branch gdb-8.1-branch
- Failures on Fedora-x86_64-cc-with-index, branch gdb-8.1-branch
- Failures on Fedora-x86_64-native-gdbserver-m64, branch gdb-8.1-branch
- Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, branch gdb-8.1-branch
- Failures on Ubuntu-AArch32-native-gdbserver-m32, branch gdb-8.1-branch
- Failures on Ubuntu-AArch32-m32, branch gdb-8.1-branch