This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] ptid_{lwp,tid}_p: Remove unnecessary checks
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Thu, 06 Apr 2017 00:11:23 -0400
- Subject: [binutils-gdb] ptid_{lwp,tid}_p: Remove unnecessary checks
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 4e9868d4e0c8e45505876901d22c021dd36972a8 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 4e9868d4e0c8e45505876901d22c021dd36972a8
ptid_{lwp,tid}_p: Remove unnecessary checks
The calls to ptid_equal in ptid_lwp_p and ptid_tid_p that compare the
argument to minus_one_ptid and null_ptid are not necessary. The calls
in question are:
if (ptid_equal (minus_one_ptid, ptid)
|| ptid_equal (null_ptid, ptid))
return 0;
minus_one_ptid is { .pid = -1, .lwp = 0, .tid = 0 }
null_ptid is { .pid = 0, .lwp = 0, .tid = 0 }
If the ptid argument is either of them, the statements
return (ptid_get_lwp (ptid) != 0);
and
return (ptid_get_tid (ptid) != 0);
will yield the same result (0/false).
gdb/ChangeLog:
* common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with
minus_one_ptid and null_ptid.